Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1131523007: Move NativeViewport service into view_manager. This is a file move only. Further merging will happe… (Closed)

Created:
5 years, 7 months ago by Ben Goodger (Google)
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move NativeViewport service into view_manager. This is a file move only. Further merging will happen subsequent to this CL. TBR=sky@chromium.org BUG= Committed: https://crrev.com/78c5825f880f5e3c8c0c7b6b8a10a89800444bbd Cr-Commit-Position: refs/heads/master@{#330672}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -1774 lines) Patch
M components/gles2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/native_viewport/BUILD.gn View 1 chunk +0 lines, -112 lines 0 comments Download
D components/native_viewport/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
D components/native_viewport/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/native_viewport/android/src/org/chromium/mojo/PlatformViewportAndroid.java View 1 chunk +0 lines, -184 lines 0 comments Download
D components/native_viewport/main.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D components/native_viewport/native_viewport_application_delegate.h View 1 1 chunk +0 lines, -60 lines 0 comments Download
D components/native_viewport/native_viewport_application_delegate.cc View 1 1 chunk +0 lines, -64 lines 0 comments Download
D components/native_viewport/native_viewport_impl.h View 1 1 chunk +0 lines, -94 lines 0 comments Download
D components/native_viewport/native_viewport_impl.cc View 1 1 chunk +0 lines, -172 lines 0 comments Download
D components/native_viewport/onscreen_context_provider.h View 1 chunk +0 lines, -51 lines 0 comments Download
D components/native_viewport/onscreen_context_provider.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D components/native_viewport/platform_viewport.h View 1 chunk +0 lines, -49 lines 0 comments Download
D components/native_viewport/platform_viewport_android.h View 1 chunk +0 lines, -86 lines 0 comments Download
D components/native_viewport/platform_viewport_android.cc View 1 chunk +0 lines, -216 lines 0 comments Download
D components/native_viewport/platform_viewport_headless.h View 1 chunk +0 lines, -39 lines 0 comments Download
D components/native_viewport/platform_viewport_headless.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D components/native_viewport/platform_viewport_stub.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D components/native_viewport/platform_viewport_win.cc View 1 chunk +0 lines, -140 lines 0 comments Download
D components/native_viewport/platform_viewport_x11.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D components/native_viewport/public/cpp/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D components/native_viewport/public/cpp/args.h View 1 chunk +0 lines, -17 lines 0 comments Download
D components/native_viewport/public/cpp/lib/args.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D components/native_viewport/public/interfaces/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D components/native_viewport/public/interfaces/native_viewport.mojom View 1 chunk +0 lines, -42 lines 0 comments Download
M components/surfaces/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/view_manager/BUILD.gn View 3 chunks +2 lines, -6 lines 0 comments Download
M components/view_manager/connection_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/display_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/event_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/native_viewport/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/view_manager/native_viewport/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/view_manager/native_viewport/android/src/org/chromium/mojo/PlatformViewportAndroid.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/view_manager/native_viewport/main.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/native_viewport/native_viewport_application_delegate.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + components/view_manager/native_viewport/native_viewport_application_delegate.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + components/view_manager/native_viewport/native_viewport_impl.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + components/view_manager/native_viewport/native_viewport_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + components/view_manager/native_viewport/onscreen_context_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/view_manager/native_viewport/onscreen_context_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/native_viewport/platform_viewport.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/view_manager/native_viewport/platform_viewport_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/view_manager/native_viewport/platform_viewport_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/native_viewport/platform_viewport_headless.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/view_manager/native_viewport/platform_viewport_headless.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/native_viewport/platform_viewport_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/native_viewport/platform_viewport_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/native_viewport/platform_viewport_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/view_manager/public/cpp/args.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/view_manager/public/cpp/lib/args.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/public/interfaces/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
A + components/view_manager/public/interfaces/native_viewport.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M components/view_manager/public/interfaces/view_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/app/android/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/aura/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/runner/BUILD.gn View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/runner/DEPS View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M mojo/runner/android/library_loader.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/android/native_viewport_application_loader.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/android/native_viewport_application_loader.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Ben Goodger (Google)
5 years, 7 months ago (2015-05-19 22:58:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131523007/40001
5 years, 7 months ago (2015-05-19 22:59:32 UTC) #4
sky
LGTM
5 years, 7 months ago (2015-05-19 23:41:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
5 years, 7 months ago (2015-05-20 01:01:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131523007/40001
5 years, 7 months ago (2015-05-20 01:46:00 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-20 01:55:02 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 01:55:53 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/78c5825f880f5e3c8c0c7b6b8a10a89800444bbd
Cr-Commit-Position: refs/heads/master@{#330672}

Powered by Google App Engine
This is Rietveld 408576698