Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: chrome/browser/metrics/thread_watcher_android_unittest.cc

Issue 1131513007: Reland (3rd try): Lazily initialize MessageLoop for faster thread startup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unnecessary include Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/metrics/thread_watcher_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 #include "base/android/application_status_listener.h" 6 #include "base/android/application_status_listener.h"
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "base/synchronization/waitable_event.h" 8 #include "base/synchronization/waitable_event.h"
9 #include "chrome/browser/metrics/thread_watcher.h" 9 #include "chrome/browser/metrics/thread_watcher.h"
10 #include "chrome/browser/metrics/thread_watcher_android.h" 10 #include "chrome/browser/metrics/thread_watcher_android.h"
(...skipping 29 matching lines...) Expand all
40 40
41 TEST(ThreadWatcherAndroidTest, ApplicationStatusNotification) { 41 TEST(ThreadWatcherAndroidTest, ApplicationStatusNotification) {
42 // Do not delay the ThreadWatcherList initialization for this test. 42 // Do not delay the ThreadWatcherList initialization for this test.
43 ThreadWatcherList::g_initialize_delay_seconds = 0; 43 ThreadWatcherList::g_initialize_delay_seconds = 0;
44 44
45 base::MessageLoopForUI message_loop_for_ui; 45 base::MessageLoopForUI message_loop_for_ui;
46 content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop_for_ui); 46 content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop_for_ui);
47 47
48 48
49 scoped_ptr<WatchDogThread> watchdog_thread_(new WatchDogThread()); 49 scoped_ptr<WatchDogThread> watchdog_thread_(new WatchDogThread());
50 watchdog_thread_->Start(); 50 watchdog_thread_->StartAndWaitForTesting();
51 51
52 EXPECT_FALSE(ThreadWatcherList::g_thread_watcher_list_); 52 EXPECT_FALSE(ThreadWatcherList::g_thread_watcher_list_);
53 53
54 54
55 // Register, and notify the application has just started, 55 // Register, and notify the application has just started,
56 // and ensure the thread watcher list is created. 56 // and ensure the thread watcher list is created.
57 ThreadWatcherAndroid::RegisterApplicationStatusListener(); 57 ThreadWatcherAndroid::RegisterApplicationStatusListener();
58 ThreadWatcherList::StartWatchingAll(*base::CommandLine::ForCurrentProcess()); 58 ThreadWatcherList::StartWatchingAll(*base::CommandLine::ForCurrentProcess());
59 NotifyApplicationStateChange( 59 NotifyApplicationStateChange(
60 base::android::APPLICATION_STATE_HAS_RUNNING_ACTIVITIES); 60 base::android::APPLICATION_STATE_HAS_RUNNING_ACTIVITIES);
61 EXPECT_TRUE(ThreadWatcherList::g_thread_watcher_list_); 61 EXPECT_TRUE(ThreadWatcherList::g_thread_watcher_list_);
62 62
63 // Notify the application has been stopped, and ensure the thread watcher list 63 // Notify the application has been stopped, and ensure the thread watcher list
64 // has been destroyed. 64 // has been destroyed.
65 NotifyApplicationStateChange( 65 NotifyApplicationStateChange(
66 base::android::APPLICATION_STATE_HAS_STOPPED_ACTIVITIES); 66 base::android::APPLICATION_STATE_HAS_STOPPED_ACTIVITIES);
67 EXPECT_FALSE(ThreadWatcherList::g_thread_watcher_list_); 67 EXPECT_FALSE(ThreadWatcherList::g_thread_watcher_list_);
68 68
69 // And again the last transition, STOPPED -> STARTED. 69 // And again the last transition, STOPPED -> STARTED.
70 NotifyApplicationStateChange( 70 NotifyApplicationStateChange(
71 base::android::APPLICATION_STATE_HAS_RUNNING_ACTIVITIES); 71 base::android::APPLICATION_STATE_HAS_RUNNING_ACTIVITIES);
72 EXPECT_TRUE(ThreadWatcherList::g_thread_watcher_list_); 72 EXPECT_TRUE(ThreadWatcherList::g_thread_watcher_list_);
73 } 73 }
OLDNEW
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/metrics/thread_watcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698