Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1131513006: Work around Clang's new -Wmismatched-new-delete warning. (Closed)

Created:
5 years, 7 months ago by hans
Modified:
5 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work around Clang's new -Wmismatched-new-delete warning. In r237368, Clang started warning about mismatched operator new[] and delete calls. This pacifies the warning by moving the operator new-call to a separate function. BUG=none Committed: https://crrev.com/cd4cce344c866b73cd7d883423f4568ab6910456 Cr-Commit-Position: refs/heads/master@{#330528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M base/debug/stack_trace_unittest.cc View 1 chunk +7 lines, -1 line 0 comments Download
M base/tools_sanity_unittest.cc View 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hans
Please take a look.
5 years, 7 months ago (2015-05-14 21:01:31 UTC) #2
Nico
lgtm
5 years, 7 months ago (2015-05-14 21:05:40 UTC) #3
hans
The warning re-landed in Clang in 237608. Let's commit this.
5 years, 7 months ago (2015-05-19 15:47:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131513006/1
5 years, 7 months ago (2015-05-19 15:49:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 17:03:24 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 17:05:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd4cce344c866b73cd7d883423f4568ab6910456
Cr-Commit-Position: refs/heads/master@{#330528}

Powered by Google App Engine
This is Rietveld 408576698