Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1131513005: remove localmatrix from GrGeometryProcessor base class (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanup4
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove localmatrix from GrGeometryProcessor base class BUG=skia: Committed: https://skia.googlesource.com/skia/+/e3ababe44315452cd33b96a18ce316ede09ff3c3

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -118 lines) Patch
M src/gpu/GrAAConvexPathRenderer.cpp View 5 chunks +13 lines, -3 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 5 chunks +12 lines, -3 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 12 chunks +29 lines, -12 lines 0 comments Download
M src/gpu/GrPathProcessor.h View 2 chunks +38 lines, -2 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 1 2 3 chunks +1 line, -37 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 4 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 2 8 chunks +22 lines, -9 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 3 chunks +10 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 10 chunks +26 lines, -6 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 1 2 9 chunks +6 lines, -14 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 1 2 2 chunks +36 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M src/gpu/gl/GrGLPathProcessor.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
joshualitt
ptal
5 years, 7 months ago (2015-05-14 18:56:10 UTC) #2
robertphillips
lgtm
5 years, 7 months ago (2015-05-14 20:12:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131513005/40001
5 years, 7 months ago (2015-05-15 14:49:07 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 14:56:14 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e3ababe44315452cd33b96a18ce316ede09ff3c3

Powered by Google App Engine
This is Rietveld 408576698