Switch //chrome functions to use SchemeIsCryptographic() instead of SchemeIsSecure().

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include "base/command_line.h"
 #include "base/debug/crash_logging.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
@@ skipping 1019 matching lines @@
       manifest_url.DomainIs("ssl.gstatic.com") &&
       (manifest_url_path.find("s2/oz/nacl/") == 1 ||
        manifest_url_path.find("photos/nacl/") == 1);
 
   std::string manifest_fs_host;
   if (manifest_url.SchemeIsFileSystem() && manifest_url.inner_url()) {
     manifest_fs_host = manifest_url.inner_url()->host();
   }
   bool is_hangouts_app =
       // Whitelisted apps must be served over secure scheme.
-      app_url.SchemeIs("https") &&

[lgarron, 2015/05/07 22:53:45]

jiayl@: The definition of is_photo_app above checks (app_url.SchemeIs("https")
&& manifest_url.SchemeIs("https").
Would you have any concerns about changing them all to SchemeIsCryptographic()?

[jiayl, 2015/05/08 21:23:40]

Sounds good to me

-      manifest_url.SchemeIsSecure() &&
+      app_url.SchemeIs("https") && manifest_url.SchemeIsCryptographic() &&

[jochen (gone - plz use gerrit), 2015/05/08 17:14:21]

why not app_url.SchemeIsCryptographic() ?

[lgarron, 2015/05/08 21:48:40]

Updated in the second patch per jiayl@'s pseudo-lgtm (in the other comment in
this file).

       manifest_url.SchemeIsFileSystem() &&
       (EndsWith(app_url_host, "talkgadget.google.com", false) ||
        EndsWith(app_url_host, "plus.google.com", false) ||
        EndsWith(app_url_host, "plus.sandbox.google.com", false)) &&
       // The manifest must be loaded from the host's FileSystem.
       (manifest_fs_host == app_url_host);
 
   bool is_whitelisted_app = is_photo_app || is_hangouts_app;
 
   bool is_extension_from_webstore = false;
@@ skipping 592 matching lines @@
                                                   const GURL& url) {
   RenderThread::Get()->Send(new ChromeViewHostMsg_RecordRapporURL(metric, url));
 }
 
 scoped_ptr<blink::WebAppBannerClient>
 ChromeContentRendererClient::CreateAppBannerClient(
     content::RenderFrame* render_frame) {
   return scoped_ptr<blink::WebAppBannerClient>(
       new AppBannerClient(render_frame));
 }