win: Add thread snapshot and memory snapshot for stacks

snapshot/win/process_reader_win.h

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #ifndef CRASHPAD_SNAPSHOT_WIN_PROCESS_READER_WIN_H_
 #define CRASHPAD_SNAPSHOT_WIN_PROCESS_READER_WIN_H_
 
 #include <sys/time.h>
 #include <windows.h>
 
 #include "util/misc/initialization_state_dcheck.h"
 #include "util/win/address_types.h"
 #include "util/win/process_info.h"
 
 namespace crashpad {
 
 //! \brief Accesses information about another process, identified by a HANDLE.
 class ProcessReaderWin {
  public:
+  //! \brief Contains information about a thread that belongs to a process.
+  struct Thread {
+    Thread();
+    ~Thread() {}
+
+    uint64_t id;
+    uint32_t suspend_count;
+    uint32_t priority_class;
+    uint32_t priority;
+    WinVMAddress teb;

[Mark Mentovai, 2015/05/08 16:54:20]

Reorder this for better packing: put the uint32s at the end.

[scottmg, 2015/05/08 18:24:02]

Done.

+    WinVMAddress stack_region_address;
+    WinVMSize stack_region_size;
+  };
+
   ProcessReaderWin();
   ~ProcessReaderWin();
 
   //! \brief Initializes this object. This method must be called before any
   //!     other.
   //!
   //! \param[in] process Process handle, must have PROCESS_QUERY_INFORMATION,
   //!     PROCESS_VM_READ, and PROCESS_DUP_HANDLE access.
   //!
   //! \return `true` on success, indicating that this object will respond
@@ skipping 19 matching lines @@
   //! \brief Determines the target process' execution time.
   //!
   //! \param[out] user_time The amount of time the process has executed code in
   //!     user mode.
   //! \param[out] system_time The amount of time the process has executed code
   //!     in kernel mode.
   //!
   //! \return `true` on success, `false` on failure, with a warning logged.
   bool CPUTimes(timeval* user_time, timeval* system_time) const;
 
+  //! \return The threads that are in the process. The first element (at index
+  //!     `0`) corresponds to the main thread.
+  const std::vector<Thread>& Threads();

[Mark Mentovai, 2015/05/08 16:54:20]

#include <vector>

[scottmg, 2015/05/08 18:24:02]

Done.

+
   //! \return The modules loaded in the process. The first element (at index
   //!     `0`) corresponds to the main executable.
   const std::vector<ProcessInfo::Module>& Modules();
 
  private:
+  //! Initializes the threads_ vector on behalf of Initialize().

[Mark Mentovai, 2015/05/08 16:54:20]

This should be // or //! \brief. (But note that although sometimes we do have
Doxygen documentation for private things, it’s not configured to generate output
for them.)

[scottmg, 2015/05/08 18:24:02]

Done. Then removed.

+  void InitializeThreads();
+
   HANDLE process_;
   ProcessInfo process_info_;
+  std::vector<Thread> threads_;
   std::vector<ProcessInfo::Module> modules_;
   InitializationStateDcheck initialized_;
 
   DISALLOW_COPY_AND_ASSIGN(ProcessReaderWin);
 };
 
 }  // namespace crashpad
 
 #endif  // CRASHPAD_SNAPSHOT_WIN_PROCESS_READER_WIN_H_