Issue 1131443003: Experiment for https://codereview.chromium.org/1134703002/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1131443003: Experiment for https://codereview.chromium.org/1134703002/ (Closed)

Created:
5 years, 7 months ago by Michael Achenbach

Modified:
5 years, 7 months ago

Reviewers:
tandrii(chromium)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Experiment for https://codereview.chromium.org/1134703002/ This should provoke a few timeouts. COMMIT=false

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -77 lines)			Patch
	M	tools/testrunner/local/commands.py	View		3 chunks	+21 lines, -77 lines	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Achenbach

This is essentially the same CL like the original but with a hardcoded timeout of ...

5 years, 7 months ago (2015-05-08 14:03:25 UTC) #1

tandrii(chromium)

5 years, 7 months ago (2015-05-08 14:16:57 UTC) #3

lgtm

https://codereview.chromium.org/1131443003/diff/1/tools/testrunner/local/comm...
File tools/testrunner/local/commands.py (right):

https://codereview.chromium.org/1131443003/diff/1/tools/testrunner/local/comm...
tools/testrunner/local/commands.py:76: process.kill()
can this raise an exception if process is already dead? suprocess docs don't say
anything :(

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages