Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 113143006: Add base:: to string16 in chrome_frame/. (Closed)

Created:
7 years ago by Dan Beam
Modified:
7 years ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, jar (doing other things), grt+watch_chromium.org, amit, robertshield, asvitkine+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Add base:: to string16 in chrome_frame/. R=grt@chromium.org BUG=329295 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -85 lines) Patch
M chrome_frame/chrome_tab.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/find_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/find_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/metrics_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/policy_settings.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome_frame/registry_list_preferences_holder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/registry_list_preferences_holder.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome_frame/simple_resource_loader.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/delete_chrome_history_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/http_negotiate_unittest.cc View 5 chunks +21 lines, -23 lines 0 comments Download
M chrome_frame/test/ie_configurator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/mock_ie_event_sink_actions.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome_frame/test/test_scrubber.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/ui_test.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome_frame/test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/turndown_prompt/turndown_prompt.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome_frame/turndown_prompt/turndown_prompt_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/turndown_prompt/turndown_prompt_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
7 years ago (2013-12-20 01:22:50 UTC) #1
grt (UTC plus 2)
rubberstamp lgtm
7 years ago (2013-12-20 14:56:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/113143006/1
7 years ago (2013-12-20 14:56:46 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-20 17:36:00 UTC) #4
Message was sent while issue was closed. 
Change committed as 242115

Powered by Google App Engine
This is Rietveld 408576698