Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 113143004: Constant evaluation support (Closed)

Created:
7 years ago by Brian Wilkerson
Modified:
7 years ago
Reviewers:
jwren, scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Constant evaluation support. This fixes most of the open issues related to constants and makes it (theoretically) possible to fix the rest. R=jwren@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=31303

Patch Set 1 #

Patch Set 2 : Clean-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5880 lines, -1061 lines) Patch
M editor/tools/plugins/com.google.dart.engine/META-INF/MANIFEST.MF View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/constant/ConstantEvaluator.java View 3 chunks +41 lines, -27 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/constant/DartObject.java View 1 chunk +84 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/constant/EvaluationResult.java View 3 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantValueComputer.java View 5 chunks +14 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java View 17 chunks +245 lines, -70 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ErrorResult.java View 20 chunks +85 lines, -47 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/EvaluationResultImpl.java View 3 chunks +75 lines, -61 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ValidResult.java View 1 22 chunks +271 lines, -746 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/hint/DeadCodeVerifier.java View 6 chunks +9 lines, -7 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/BoolState.java View 1 chunk +160 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/DartObjectImpl.java View 1 chunk +542 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/DoubleState.java View 1 chunk +361 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/DynamicState.java View 1 chunk +202 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/EvaluationException.java View 1 chunk +46 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/FunctionState.java View 1 chunk +83 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/GenericState.java View 1 chunk +92 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/InstanceState.java View 1 chunk +407 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/IntState.java View 1 chunk +481 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/ListState.java View 1 chunk +83 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/MapState.java View 1 chunk +88 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/NullState.java View 1 chunk +82 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/NumState.java View 1 chunk +148 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/StringState.java View 1 chunk +116 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/SymbolState.java View 1 chunk +92 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/TypeState.java View 1 chunk +83 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryResolver.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ConstantVerifier.java View 11 chunks +46 lines, -20 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java View 4 chunks +11 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/constant/ConstantEvaluatorTest.java View 6 chunks +33 lines, -35 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/TestAll.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java View 6 chunks +6 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantVisitorTest.java View 5 chunks +15 lines, -15 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/object/DartObjectImplTest.java View 1 chunk +1870 lines, -0 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/object/TestAll.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java View 1 chunk +0 lines, -7 lines 0 comments Download
M tests/co19/co19-analyzer.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Brian Wilkerson
7 years ago (2013-12-19 19:39:18 UTC) #1
scheglov
lgtm
7 years ago (2013-12-19 20:03:57 UTC) #2
jwren
LGTM
7 years ago (2013-12-19 21:07:28 UTC) #3
Brian Wilkerson
7 years ago (2013-12-19 21:27:11 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r31303 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698