Add histograms for deletion of session cookies on startup.

content/browser/net/sqlite_persistent_cookie_store.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/net/sqlite_persistent_cookie_store.h"
 
 #include <list>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 683 matching lines @@
       50);
 
   UMA_HISTOGRAM_CUSTOM_TIMES(
       "Cookie.TimeInitializeDomainMap",
       base::Time::Now() - start,
       base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(1),
       50);
 
   initialized_ = true;
 
-  if (!restore_old_session_cookies_)
+  int deleted_cookies_count = 0;

[erikwright (departed), 2015/05/12 14:30:43]

Assuming you agree with my comment below, move count declaration to line 714 and
inline the calculation of elapsed time on line 712.

[erikchen, 2015/05/12 18:50:34]

I removed the variables elapsed_time and deleted_cookies_count.

+  base::TimeDelta elapsed_time;
+  if (!restore_old_session_cookies_) {
+    base::Time start_time = base::Time::Now();
     DeleteSessionCookiesOnStartup();
+
+    elapsed_time = base::Time::Now() - start_time;
+    UMA_HISTOGRAM_TIMES("Cookie.Startup.TimeSpentDeletingCookies",
+                        elapsed_time);
+
+    deleted_cookies_count = db_->GetLastChangeCount();
+    UMA_HISTOGRAM_COUNTS("Cookie.Startup.NumberOfCookiesDeleted",
+                         deleted_cookies_count);
+  }
+
+  if (deleted_cookies_count > 0) {

[erikwright (departed), 2015/05/12 14:30:43]

I'm not convinced that this is useful. In any case, it can be generated via
dremel (query for UMA uploads containg both the TimeSpent.. and
NumberOfCookies.. and do the division there).

What would be more interesting would be to do a scatterplot of those two
numbers, to see if there is a clear relationship between them.

[erikchen, 2015/05/12 18:50:34]

I wasn't aware that this was easy to do with dremel. I'm guessing that the
scatterplot you're referring to is also done via dremel? 

I've removed this histogram.

+    base::TimeDelta avg_deletion_time = elapsed_time / deleted_cookies_count;
+    UMA_HISTOGRAM_TIMES("Cookie.Startup.AverageTimeSpentDeletingOneCookie",
+                        avg_deletion_time);
+  }
+
   return true;
 }
 
 void SQLitePersistentCookieStore::Backend::ChainLoadCookies(
     const LoadedCallback& loaded_callback) {
   DCHECK(background_task_runner_->RunsTasksOnCurrentThread());
   IncrementTimeDelta increment(&cookie_load_duration_);
 
   bool load_success = true;
 
@@ skipping 734 matching lines @@
         (config.session_cookie_mode ==
          CookieStoreConfig::RESTORED_SESSION_COOKIES)) {
       cookie_monster->SetPersistSessionCookies(true);
     }
   }
 
   return cookie_monster;
 }
 
 }  // namespace content