Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1131403003: bisect-builds.py: Save cache in parent scope (Closed)

Created:
5 years, 7 months ago by robwu
Modified:
5 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bisect-builds.py: Save cache in parent scope Using 'cache = ...' always assigns ... to the local scope, while it should be stored in the parent scope instead. Because of this oversight, the cache only contained one list of revisions at any time, namely the list of revisions for the current settings (e.g. "-a linux64" or "-l -a linux64"). This patch fixed the issue by iterating over the cached dictionary and copying the keys and values to the variable (in the parent scope). R=rsesek@chromium.org Committed: https://crrev.com/1c83605f861223ad3b744c0c6fc93f97d3d2b639 Cr-Commit-Position: refs/heads/master@{#330374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/bisect-builds.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
robwu
5 years, 7 months ago (2015-05-16 12:40:58 UTC) #1
Robert Sesek
lgtm
5 years, 7 months ago (2015-05-18 15:56:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131403003/1
5 years, 7 months ago (2015-05-18 16:25:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 16:34:10 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:40:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c83605f861223ad3b744c0c6fc93f97d3d2b639
Cr-Commit-Position: refs/heads/master@{#330374}

Powered by Google App Engine
This is Rietveld 408576698