Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py

Issue 11314012: Add spaceport benchmark to Chrome Remote Control. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't display warning if all urls in page set are file urls Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py
diff --git a/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py b/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py
index 052fdb7a88162fb0d1b9890d0c566444a75b65e9..07907618a82cf598fe2d68c67f539b87e17cb5e6 100644
--- a/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py
+++ b/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py
@@ -85,7 +85,11 @@ class CsvBenchmarkResults(BenchmarkResults):
def PrintSummary(self, trace_tag):
for measurement_units, values in self.results_summary.iteritems():
measurement, units = measurement_units
- trace = measurement + (trace_tag or '')
nduca 2012/11/04 19:53:30 what is this '.'? Can we make this less hacky feel
tonyg 2012/11/05 23:02:01 The perfbots support a chart and a trace as the "k
+ if '.' in measurement:
+ measurement, trace = measurement.split('.', 1)
+ trace += (trace_tag or '')
+ else:
+ trace = measurement + (trace_tag or '')
PrintPerfResult(measurement, trace, values, units)

Powered by Google App Engine
This is Rietveld 408576698