chrome/browser/sessions/session_restore_delegate.cc - Issue 1131373003: [Session restore] Add MRU logic to loading of background pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/session_restore_delegate.cc

Issue 1131373003: [Session restore] Add MRU logic to loading of background pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge to ToT for Time => TimeTicks. Sanitize the times. More covergae on test. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sessions/session_restore.cc ('K') | « chrome/browser/sessions/session_restore_browsertest.cc ('k') | chrome/browser/sessions/session_service.h » ('j') | components/sessions/session_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/session_restore_delegate.cc

diff --git a/chrome/browser/sessions/session_restore_delegate.cc b/chrome/browser/sessions/session_restore_delegate.cc

index 9d5c3122709459dff1f353967f51ca45e44af392..52564f97adf048836da07c485e0ff02248b2d72b 100644

--- a/chrome/browser/sessions/session_restore_delegate.cc

+++ b/chrome/browser/sessions/session_restore_delegate.cc

@@ -57,7 +57,11 @@ bool SessionRestoreDelegate::RestoredTab::operator<(

// Apps should be loaded before normal tabs.

if (is_app_ != right.is_app_)

return is_app_;

- // TODO(georgesak): Add criterion based on recency.

+ // Restore using MRU. Behind an experiment for now.

+ if (SessionRestore::GetSmartRestoreMode() ==

+ SessionRestore::SMART_RESTORE_MODE_MRU)

+ return contents_->GetLastActiveTime() >

+ right.contents_->GetLastActiveTime();

return false;

}