Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1131363003: Revert of Add support for escaped target names in isolate driver (3rd try) (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
Reviewers:
nyquist, Vadim Sh.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for escaped target names in isolate driver (3rd try) (patchset #2 id:20001 of https://codereview.chromium.org/1130523003/) Reason for revert: Looks like interactive_ui_tests needs a dep on chrome too: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/40889/steps/compile/logs/stdio FAILED: cd ../../chrome; python ../tools/isolate_driver.py check --isolated "../out/Release/interactive_ui_tests.isolated" --isolate "interactive_ui_tests.isolate" --path-variable DEPTH .. --path-variable PRODUCT_DIR "../out/Release " --extra-variable "version_full=44.0.2398.0" --config-variable "CONFIGURATION_NAME=Release" --config-variable "OS=linux" --config-variable "asan=0" --config-variable "branding=Chrome" --config-variable "chromeos=0" --config-variable "component=static_library" --config-variable "disable_nacl=0" --config-variable "enable_pepper_cdms=1" --config-variable "enable_plugins=1" --config-variable "fastbuild=0" --config-variable "icu_use_data_file_flag=1" --config-variable "internal_gles2_conform_tests=0" --config-variable "kasko=0" --config-variable "libpeer_target_type=static_library" --config-variable "lsan=0" --config-variable "msan=0" --config-variable "target_arch=ia32" --config-variable "tsan=0" --config-variable "use_custom_libcxx=0" --config-variable "use_instrumented_libraries=0" --config-variable "use_prebuilt_instrumented_libraries=0" --config-variable "use_openssl=0" --config-variable "use_ozone=0" --config-variable "use_x11=1" --config-variable "v8_use_external_startup_data=1" Failed to find an input file: Input file /b/build/slave/google-chrome-rel-linux/build/src/out/Release/chrome doesn't exist Reverting for now, but should be easy to fix. Original issue's description: > Add support for escaped target names in isolate driver (3rd try) > > Currently the isolate_driver.py which creates the dependency files > used by the isolate system, does a simple split on all spaces when > trying to identify targets. > > This can fail if the target name contains a space in the name. In > ninja, spaces are escaped with a $-prefix. An example would be > 'Content$ Shell$ Helper.app'. > > This CL adds support for such target names and ensures that they > stay as one item. Doing this uncovered a few missing dependencies > and a missing file in some .isolate-files for the component build > on Mac. > > 1st try: https://codereview.chromium.org/970203003/ > 1st revert: https://codereview.chromium.org/985753002/ > 2nd try: https://codereview.chromium.org/1103793002/ > 2nd revert: https://codereview.chromium.org/1129493003/ > BUG=462248 > > Committed: https://crrev.com/e94fb8bb82056ce3a255691a9326fd12707cf0cb > Cr-Commit-Position: refs/heads/master@{#329038} TBR=vadimsh@chromium.org,nyquist@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462248 Committed: https://crrev.com/3d06cd37c4d15cf75a396ec528fd362f18b2c066 Cr-Commit-Position: refs/heads/master@{#329064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M chrome/chrome.isolate View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/sync_integration_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/isolate_driver.py View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Add support for escaped target names in isolate driver (3rd try)
5 years, 7 months ago (2015-05-10 16:29:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131363003/1
5 years, 7 months ago (2015-05-10 16:30:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-10 16:38:56 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-10 16:39:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d06cd37c4d15cf75a396ec528fd362f18b2c066
Cr-Commit-Position: refs/heads/master@{#329064}

Powered by Google App Engine
This is Rietveld 408576698