Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1131333003: clang/win: Enable oilpan plugin on 64-bit builds again. (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Enable oilpan plugin on 64-bit builds again. This reverts https://codereview.chromium.org/1129103005/ , which turned them off. Now what all [blink-gc] warnings are fixed, we can turn them on again on the warnings-as-errors 64-bit builds. BUG=486571, 467287 TBR=hans Committed: https://crrev.com/d346fc108e63d2d2e318ecf04bf03bb273e5f3e7 Cr-Commit-Position: refs/heads/master@{#330313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Nico
Created Revert of clang/win: Disable oilpan plugin on 64-bit builds again.
5 years, 7 months ago (2015-05-17 19:22:35 UTC) #1
Nico
5 years, 7 months ago (2015-05-17 19:24:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131333003/1
5 years, 7 months ago (2015-05-17 19:24:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-17 20:24:47 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d346fc108e63d2d2e318ecf04bf03bb273e5f3e7 Cr-Commit-Position: refs/heads/master@{#330313}
5 years, 7 months ago (2015-05-18 11:33:02 UTC) #6
hans
5 years, 7 months ago (2015-05-18 16:18:21 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698