Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Unified Diff: content/browser/service_worker/service_worker_job_coordinator.h

Issue 113133013: Refactor job coordination into a separate class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove WeakPtr usage from Storage Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_job_coordinator.h
diff --git a/content/browser/service_worker/service_worker_job_coordinator.h b/content/browser/service_worker/service_worker_job_coordinator.h
new file mode 100644
index 0000000000000000000000000000000000000000..46ead776e7e126d899a1524121f6cc8d82833b61
--- /dev/null
+++ b/content/browser/service_worker/service_worker_job_coordinator.h
@@ -0,0 +1,69 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_JOB_COORDINATOR_H_
+#define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_JOB_COORDINATOR_H_
+
+#include "base/bind.h"
+#include "base/memory/scoped_vector.h"
+#include "content/browser/service_worker/service_worker_register_job.h"
+#include "content/browser/service_worker/service_worker_registration_status.h"
+#include "content/browser/service_worker/service_worker_storage.h"
+#include "content/common/content_export.h"
+#include "url/gurl.h"
+
+namespace content {
+
+class ServiceWorkerRegistration;
+
+// This class manages all in-flight jobs. Any asynchronous
+// operations are run through instances of ServiceWorkerRegisterJob.
+class CONTENT_EXPORT ServiceWorkerJobCoordinator {
+ public:
+ ServiceWorkerJobCoordinator(ServiceWorkerStorage* storage);
+ ~ServiceWorkerJobCoordinator();
+
+ void Register(const GURL& pattern,
+ const GURL& script_url,
+ const ServiceWorkerRegisterJob::RegistrationCallback& callback);
+
+ void Unregister(
+ const GURL& pattern,
+ const ServiceWorkerRegisterJob::UnregistrationCallback& callback);
+
+ private:
+ friend class ServiceWorkerRegisterJob;
+
+ typedef ScopedVector<ServiceWorkerRegisterJob> RegistrationJobList;
+
+ // Jobs are removed whenever they are finished or canceled.
+ void EraseJob(ServiceWorkerRegisterJob* job);
+
+ // Called at ServiceWorkerRegisterJob completion.
+ void RegisterComplete(
+ const ServiceWorkerRegisterJob::RegistrationCallback& callback,
+ ServiceWorkerRegisterJob* job,
+ ServiceWorkerRegistrationStatus status,
+ ServiceWorkerRegistration* registration);
+
+ // Called at ServiceWorkerRegisterJob completion.
+ void UnregisterComplete(
+ const ServiceWorkerRegisterJob::UnregistrationCallback& callback,
+ ServiceWorkerRegisterJob* job,
+ ServiceWorkerRegistrationStatus status,
+ ServiceWorkerRegistration* registration);
+
+ // The ServiceWorkerStorage object should always outlive this
kinuko 2014/01/09 01:41:59 nit: end comments with period
+ ServiceWorkerStorage* storage_;
+ base::WeakPtrFactory<ServiceWorkerJobCoordinator> weak_factory_;
+ // A list of currently running jobs. This is a temporary structure until we
+ // start managing overlapping registrations explicitly.
+ RegistrationJobList registration_jobs_;
+
+ DISALLOW_COPY_AND_ASSIGN(ServiceWorkerJobCoordinator);
+};
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_JOB_COORDINATOR_H_

Powered by Google App Engine
This is Rietveld 408576698