Refactor job coordination into a separate class.

content/browser/service_worker/service_worker_context_core.cc

Index: content/browser/service_worker/service_worker_context_core.cc
diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc
index 048d33bd836da9455bdc8fef0456b1b2cd16c341..ef5927739fc6edf41b63e61f15260451bc259c70 100644
--- a/content/browser/service_worker/service_worker_context_core.cc
+++ b/content/browser/service_worker/service_worker_context_core.cc
@@ -22,6 +22,7 @@ ServiceWorkerContextCore::ServiceWorkerContextCore(
     const base::FilePath& path,
     quota::QuotaManagerProxy* quota_manager_proxy)
     : storage_(new ServiceWorkerStorage(path, quota_manager_proxy)),
+      job_coordinator_(new ServiceWorkerJobCoordinator(storage_->AsWeakPtr())),

[kinuko, 2013/12/18 05:43:35]

I think probably this should take ContextCore's weakptr rather than storage's. 
Storage and other related classes can be accessed via context, and the loss of
context's weakptr indicates the loss of storage.

[alecflett, 2014/01/06 21:47:12]

My interest here is more around encapsulation and testing - I imagine that
ContextCore is going to continue to grow, and by limiting exposure to Storage,
it's easier to test the registration process.

[kinuko, 2014/01/08 06:19:10]

I rather think that we can always create a small ContextCore for tests and which
could make things simpler, rather than making many objects depend on each
other's weak ptr separately.

...actually looking into the code more Storage and JobCoordinator (and
ContextCore) seem to have the same life time at least in the current
implementation, since both are owned by ContextCore.

Can we just remove this WeakPtr notion and add an explicit comment that (at
least in the current implementation) they all must have the same lifetime?

       embedded_worker_registry_(new EmbeddedWorkerRegistry(AsWeakPtr())) {}
 
 ServiceWorkerContextCore::~ServiceWorkerContextCore() {}
@@ -69,11 +70,12 @@ void ServiceWorkerContextCore::RegisterServiceWorker(
     const RegistrationCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
-  storage_->Register(pattern,
-                     script_url,
-                     base::Bind(&ServiceWorkerContextCore::RegistrationComplete,
-                                AsWeakPtr(),
-                                callback));
+  job_coordinator_->Register(
+      pattern,
+      script_url,
+      base::Bind(&ServiceWorkerContextCore::RegistrationComplete,
+                 AsWeakPtr(),
+                 callback));
 }
 
 void ServiceWorkerContextCore::UnregisterServiceWorker(
@@ -81,7 +83,7 @@ void ServiceWorkerContextCore::UnregisterServiceWorker(
     const UnregistrationCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
-  storage_->Unregister(pattern, callback);
+  job_coordinator_->Unregister(pattern, callback);
 }
 
 void ServiceWorkerContextCore::RegistrationComplete(