Flag for auto-reload work.

Flag for auto-reload work.

BUG=308233
R=ellyjones@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241204

[Randy Smith (Not in Mondays), 2013-12-11 22:11:29]

I'll ask for review on the basis of getting a successful trybot compile.  Elly?

[Elly Fong-Jones, 2013-12-16 17:32:29]

lgtm

[commit-bot: I haz the power, 2013-12-16 17:48:30]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Randy Smith (Not in Mondays), 2013-12-16 17:51:48]

Matt?  I need a committer LGTM.

[mmenke, 2013-12-16 18:27:47]

On 2013/12/16 17:51:48, rdsmith wrote:
> Matt?  I need a committer LGTM.

I'd assumed Elly was already a committer.  Do we really need to hook up
something in about:flags?

[Randy Smith (Not in Mondays), 2013-12-16 18:57:22]

She says that she doesn't think so, and as best I can tell, any committer should
be good for this.  

What's the argument against hooking it up in about:flags?  If it's not in flags,
that means we need to be using command line args, which is an (admittedly minor)
pain.

[mmenke, 2013-12-16 19:38:00]

On 2013/12/16 18:57:22, rdsmith wrote:
> She says that she doesn't think so, and as best I can tell, any committer
should
> be good for this.  
> 
> What's the argument against hooking it up in about:flags?  If it's not in
flags,
> that means we need to be using command line args, which is an (admittedly
minor)
> pain.

about:flags bloat.  There are currently 161 flags listed.

[Randy Smith (Not in Mondays), 2013-12-16 19:50:45]

So if you ask me again, I'll pull it out.  But I want to first make the case for
it.

about:flags, much like command line switches, is for things we expect to be
there temporarily.  Thus, as far as I'm concerned, committing anything to either
place involves a commitment to pull it back out when you're done/have given up
on the feature.  I know that that hasn't historically been done, and I"m not
claiming to be particularly more virtuous than my peers (though I do plan to
remove the flag from both places after the feature's solid).  But I don't see a
reason to keep something out of about:flags unless there's the same reason to
keep it out of command line switches.  In favor, putting it in about:flags makes
it easier both for developers (e.g. Elly and I) and anyone else who wants to
play around with the feature to do so (not a strong reason in favor, but as best
I know, the same reason in favor of anything in about:flags).

Having said all that, if you don't want it in about:flags, I'll remove it--just
let me know.

[mmenke, 2013-12-16 21:01:00]

LGTM.  Hmm...TCP fastopen is still in about:flags...What ever happened to that
work?

[Randy Smith (Not in Mondays), 2013-12-16 21:09:12]

If you want to make me feel guilty :-}, I'd recommend the other offline flag,
which I don't think (but am not absolutely sure) will ever be productized. 
Jana's taking over the TCP Fast Open work.

[mmenke, 2013-12-16 21:14:24]

On 2013/12/16 21:09:12, rdsmith wrote:
> If you want to make me feel guilty :-}, I'd recommend the other offline flag,
> which I don't think (but am not absolutely sure) will ever be productized. 
> Jana's taking over the TCP Fast Open work.

I'd have to look through the entire list to see which were yours, and I'm lazy. 
I just noticed that one because it was near the end.  Or could do a blame, or
check the changelog, I suppose.

[commit-bot: I haz the power, 2013-12-16 21:15:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdsmith@chromium.org/113133004/20001

[commit-bot: I haz the power, 2013-12-17 01:36:56]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-12-17 03:01:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdsmith@chromium.org/113133004/20001

[commit-bot: I haz the power, 2013-12-17 08:05:40]

Change committed as 241204