Rewrite to not store type in m_type and also remove type getter/setter.

Rewrite to not store type in m_type and also remove type getter/setter.

Make sure SVGScriptElement can use fastGetAttribute for attribute "type" by overriding isAnimatableAttribute. Now we can use Reflect to access type from js and can remove m_type.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166559

[rwlbuis, 2013-12-11 20:06:06]

Based on WebKit change:

http://trac.webkit.org/changeset/160389

[pdr., 2013-12-11 20:08:30]

On 2013/12/11 20:06:06, rwlbuis wrote:
> Based on WebKit change:
> 
> http://trac.webkit.org/changeset/160389

LGTM, thanks for bringing this over.

[commit-bot: I haz the power, 2013-12-11 20:28:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/113133002/1

[commit-bot: I haz the power, 2013-12-11 22:00:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/113133002/20001

[commit-bot: I haz the power, 2013-12-12 00:41:09]

Retried try job too often on linux_blink for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[pdr., 2013-12-12 00:48:52]

On 2013/12/12 00:41:09, I haz the power (commit-bot) wrote:
> Retried try job too often on linux_blink for step(s) webkit_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

This failure looks real to me.

[rwlbuis, 2013-12-12 14:56:40]

On 2013/12/12 00:48:52, pdr wrote:
> On 2013/12/12 00:41:09, I haz the power (commit-bot) wrote:
> > Retried try job too often on linux_blink for step(s) webkit_tests
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
> 
> This failure looks real to me.

The problem is the fact that type is animatable in some cases but not in others.
In this case, for SVGScriptElement it is not animatable so there should be no
assert. I'll make a new patch to fix this, but I think it will need a quick look
over before it can go in.

[rwlbuis, 2014-02-05 17:58:39]

On 2013/12/12 14:56:40, rwlbuis wrote:
> On 2013/12/12 00:48:52, pdr wrote:
> > On 2013/12/12 00:41:09, I haz the power (commit-bot) wrote:
> > > Retried try job too often on linux_blink for step(s) webkit_tests
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
> > 
> > This failure looks real to me.
> 
> The problem is the fact that type is animatable in some cases but not in
others.
> In this case, for SVGScriptElement it is not animatable so there should be no
> assert. I'll make a new patch to fix this, but I think it will need a quick
look
> over before it can go in.

Picking this up again. I think I need to port over
http://trac.webkit.org/changeset/160544 to fix the problem.

[pdr., 2014-02-05 21:13:52]

On 2014/02/05 17:58:39, rwlbuis wrote:
> On 2013/12/12 14:56:40, rwlbuis wrote:
> > On 2013/12/12 00:48:52, pdr wrote:
> > > On 2013/12/12 00:41:09, I haz the power (commit-bot) wrote:
> > > > Retried try job too often on linux_blink for step(s) webkit_tests
> > > >
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
> > > 
> > > This failure looks real to me.
> > 
> > The problem is the fact that type is animatable in some cases but not in
> others.
> > In this case, for SVGScriptElement it is not animatable so there should be
no
> > assert. I'll make a new patch to fix this, but I think it will need a quick
> look
> > over before it can go in.
> 
> Picking this up again. I think I need to port over
> http://trac.webkit.org/changeset/160544 to fix the problem.

LGTM

[rwlbuis, 2014-02-05 21:14:30]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-02-05 21:14:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/113133002/180001

[commit-bot: I haz the power, 2014-02-06 00:08:41]

Change committed as 166559