Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/browser/push_messaging/push_messaging_browsertest.cc

Issue 1131303002: Cleanup PushMessagingAppIdentifier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_identifier
Patch Set: Undo accidental test change Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/push_messaging/push_messaging_browsertest.cc
diff --git a/chrome/browser/push_messaging/push_messaging_browsertest.cc b/chrome/browser/push_messaging/push_messaging_browsertest.cc
index fe531d2b46a5b5867e32fd59e9094af50e6cc804..6dab03aee9aca08952e47bcc9aa16a39fac387ea 100644
--- a/chrome/browser/push_messaging/push_messaging_browsertest.cc
+++ b/chrome/browser/push_messaging/push_messaging_browsertest.cc
@@ -248,7 +248,7 @@ PushMessagingBrowserTest::GetAppIdentifierForServiceWorkerRegistration(
GURL origin = https_server()->GetURL(std::string()).GetOrigin();
PushMessagingAppIdentifier app_identifier = PushMessagingAppIdentifier::Get(
GetBrowser()->profile(), origin, service_worker_registration_id);
- EXPECT_TRUE(app_identifier.IsValid());
+ EXPECT_FALSE(app_identifier.is_null());
return app_identifier;
}
@@ -1038,7 +1038,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
PushMessagingAppIdentifier stored_app_identifier =
PushMessagingAppIdentifier::Get(GetBrowser()->profile(),
app_identifier.app_id());
- EXPECT_TRUE(stored_app_identifier.IsValid());
+ EXPECT_FALSE(stored_app_identifier.is_null());
// Simulate a user clearing site data (including Service Workers, crucially).
BrowsingDataRemover* remover =
@@ -1065,7 +1065,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
PushMessagingAppIdentifier stored_app_identifier2 =
PushMessagingAppIdentifier::Get(GetBrowser()->profile(),
app_identifier.app_id());
- EXPECT_FALSE(stored_app_identifier2.IsValid());
+ EXPECT_TRUE(stored_app_identifier2.is_null());
}
class PushMessagingIncognitoBrowserTest : public PushMessagingBrowserTest {

Powered by Google App Engine
This is Rietveld 408576698