components/network_hints/renderer/prescient_networking_dispatcher.h - Issue 1131293004: Add cross origin to Blink-driven preconnect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/network_hints/renderer/prescient_networking_dispatcher.h

Issue 1131293004: Add cross origin to Blink-driven preconnect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ryan's concerns Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/preconnect.cc ('K') | « components/network_hints/common/network_hints_messages.h ('k') | components/network_hints/renderer/prescient_networking_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/network_hints/renderer/prescient_networking_dispatcher.h

diff --git a/components/network_hints/renderer/prescient_networking_dispatcher.h b/components/network_hints/renderer/prescient_networking_dispatcher.h

index 3b2219e48d5a58f4234cd005579329bb2369f353..1810aa03104b9056ff6c986f3ab78261d5b50182 100644

--- a/components/network_hints/renderer/prescient_networking_dispatcher.h

+++ b/components/network_hints/renderer/prescient_networking_dispatcher.h

@@ -19,8 +19,11 @@ class PrescientNetworkingDispatcher : public blink::WebPrescientNetworking {

PrescientNetworkingDispatcher();

~PrescientNetworkingDispatcher() override;

- void prefetchDNS(const blink::WebString& hostname) override;

- void preconnect(const blink::WebURL& url) override;

+ virtual void prefetchDNS(const blink::WebString& hostname) override;

+ // TODO(yoav): Remove the old version of the API

+ virtual void preconnect(const blink::WebURL& url);

+ virtual void preconnect(const blink::WebURL& url,

+ const bool allow_credentials) override;

private:

network_hints::RendererDnsPrefetch dns_prefetch_;