chrome/browser/net/predictor_unittest.cc - Issue 1131293004: Add cross origin to Blink-driven preconnect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/predictor_unittest.cc

Issue 1131293004: Add cross origin to Blink-driven preconnect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ryan's concerns Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/predictor_unittest.cc

diff --git a/chrome/browser/net/predictor_unittest.cc b/chrome/browser/net/predictor_unittest.cc

index 76c7333310757b936863fcdf5d62482b0620b2d9..61460aee150163d7beebd812b5ca6d7dcb45a2a4 100644

--- a/chrome/browser/net/predictor_unittest.cc

+++ b/chrome/browser/net/predictor_unittest.cc

@@ -731,7 +731,8 @@ TEST_F(PredictorTest, HSTSRedirect) {

predictor.SetObserver(&observer);

predictor.SetTransportSecurityState(&state);

- predictor.PreconnectUrl(kHttpUrl, GURL(), UrlInfo::OMNIBOX_MOTIVATED, 2);

+ predictor.PreconnectUrl(kHttpUrl, GURL(), UrlInfo::OMNIBOX_MOTIVATED, true,

+ 2);

ASSERT_EQ(1u, observer.preconnected_urls_.size());

EXPECT_EQ(kHttpsUrl, observer.preconnected_urls_[0]);