Add cross origin to Blink-driven preconnect

chrome/browser/net/preconnect.cc

Index: chrome/browser/net/preconnect.cc
diff --git a/chrome/browser/net/preconnect.cc b/chrome/browser/net/preconnect.cc
index dfa91a3195341b58603112fbae57b665a2d314b5..1214ed5e221cbc2dcfc37f76b86e6b24099d3df9 100644
--- a/chrome/browser/net/preconnect.cc
+++ b/chrome/browser/net/preconnect.cc
@@ -8,6 +8,7 @@
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "content/public/browser/browser_thread.h"
+#include "net/base/load_flags.h"
 #include "net/http/http_network_session.h"
 #include "net/http/http_request_info.h"
 #include "net/http/http_stream_factory.h"
@@ -30,20 +31,18 @@ void PreconnectOnUIThread(
     net::URLRequestContextGetter* getter) {
   // Prewarm connection to Search URL.
   BrowserThread::PostTask(
-      BrowserThread::IO,
-      FROM_HERE,
+      BrowserThread::IO, FROM_HERE,
       base::Bind(&PreconnectOnIOThread, url, first_party_for_cookies,
-                 motivation, count, make_scoped_refptr(getter)));
+                 motivation, count, make_scoped_refptr(getter), true));
   return;
 }
 
-
-void PreconnectOnIOThread(
-    const GURL& url,
-    const GURL& first_party_for_cookies,
-    UrlInfo::ResolutionMotivation motivation,
-    int count,
-    net::URLRequestContextGetter* getter) {
+void PreconnectOnIOThread(const GURL& url,
+                          const GURL& first_party_for_cookies,
+                          UrlInfo::ResolutionMotivation motivation,
+                          int count,
+                          net::URLRequestContextGetter* getter,
+                          bool allow_credentials) {
   if (!BrowserThread::CurrentlyOn(BrowserThread::IO)) {
     LOG(DFATAL) << "This must be run only on the IO thread.";
     return;
@@ -68,7 +67,11 @@ void PreconnectOnIOThread(
                                        user_agent);
 
   net::NetworkDelegate* delegate = context->network_delegate();
-  if (delegate->CanEnablePrivacyMode(url, first_party_for_cookies))
+  // TODO(yoav): Fix this layering violation, since when credentials are not
+  // allowed we should turn on a flag indicating that, rather then turn on
+  // private mode, even if lower layers would treat both the same.
+  if (delegate->CanEnablePrivacyMode(url, first_party_for_cookies) ||
+      !allow_credentials)
     request_info.privacy_mode = net::PRIVACY_MODE_ENABLED;

[Ryan Sleevi, 2015/07/23 18:22:41]

Sorry, I'm still out rather sick, but saw this ended up going through CQ, and
it's still wrong.

This needs to at least make sure to set the LoadFlags to the relevant 3 flags
from the WebURLRequest *in addition to* setting the privacy mode flag.

You want this file to be consistent with the behaviour of WebURLRequest in how
it maps to URLRequests.

 
   // Translate the motivation from UrlRequest motivations to HttpRequest