Add cross origin to Blink-driven preconnect

components/network_hints/renderer/renderer_preconnect.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See header file for description of RendererPreconnect class
 
 #include "components/network_hints/renderer/renderer_preconnect.h"
 
 #include "components/network_hints/common/network_hints_common.h"
 #include "components/network_hints/common/network_hints_messages.h"
 #include "content/public/renderer/render_thread.h"
 
 using content::RenderThread;
 
 namespace network_hints {
 
 RendererPreconnect::RendererPreconnect() {
 }
 
 RendererPreconnect::~RendererPreconnect() {
 }
 
-void RendererPreconnect::Preconnect(const GURL &url) {
+void RendererPreconnect::Preconnect(const GURL &url,
+    blink::CrossOriginAttributeValue crossOrigin) {
   if (!url.is_valid())
     return;
 
+  bool isAnonymous = (crossOrigin == blink::CrossOriginAttributeAnonymous);

[Ryan Sleevi, 2015/06/10 19:30:42]

This isn't really correct, is it? You should be gating it on whether or not the
CORS credentials flag is set, which happens to be not set in anonymous mode.

[Ryan Sleevi, 2015/06/11 18:30:09]

Yoav wrote:
No, I mean this code should not at all be dealing with CrossOriginAttribute.
That's not the pivot point for the API, as reflected in Fetch.

https://fetch.spec.whatwg.org/#http-network-fetch

"HTTP requests should be grouped based on the credentials flag. HTTP requests
with the credentials flag set should not share anything about the connection or
TLS particulars (such as session identifiers) with HTTP requests that have the
credentials flag unset. In other words, ambient authority should not leak across
this grouping."

The CrossOriginAttribute is just Blink's way of tracking that Fetch attribute,
but the algorithm in 4.3 establishes

"Let credentials flag be set if either request's credentials mode is "include",
or request's credentials mode is "same-origin" and the CORS flag is unset, and
unset otherwise."

I'm saying that the distinction about "isAnonymous" is wrong. For preconnect (or
for prefetch, for that matter), the "which pool to go to" is keyed on the
credentials flag.

   RenderThread::Get()->Send(
-      new NetworkHintsMsg_Preconnect(url, 1));
+      new NetworkHintsMsg_Preconnect(url, isAnonymous, 1));
 }
 
 }  // namespace network_hints