Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1131283005: Update media-router-container CSS. (Closed)

Created:
5 years, 7 months ago by apacible
Modified:
5 years, 7 months ago
Reviewers:
mark a. foltz
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update media-router-container CSS. Remove unneeded CSS and add styling to drop-down-button for aesthetic changes. z-index added so that the button will appear above the transparent overlay. Committed: https://crrev.com/a632964f7bde7695cd3119705360fd75f030e21c Cr-Commit-Position: refs/heads/master@{#329180}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css View 1 chunk +3 lines, -2 lines 2 comments Download

Messages

Total messages: 13 (5 generated)
apacible
PTAL, thanks!
5 years, 7 months ago (2015-05-08 23:05:03 UTC) #3
mark a. foltz
lgtm https://codereview.chromium.org/1131283005/diff/20001/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css File chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css (right): https://codereview.chromium.org/1131283005/diff/20001/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css#newcode34 chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css:34: #drop-down-button { Does this patch apply to the ...
5 years, 7 months ago (2015-05-09 06:22:58 UTC) #4
apacible
https://codereview.chromium.org/1131283005/diff/20001/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css File chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css (right): https://codereview.chromium.org/1131283005/diff/20001/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css#newcode34 chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css:34: #drop-down-button { On 2015/05/09 06:22:58, mark a. foltz wrote: ...
5 years, 7 months ago (2015-05-09 07:03:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131283005/20001
5 years, 7 months ago (2015-05-09 07:10:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-09 12:16:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131283005/20001
5 years, 7 months ago (2015-05-11 15:59:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-11 18:01:40 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 18:03:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a632964f7bde7695cd3119705360fd75f030e21c
Cr-Commit-Position: refs/heads/master@{#329180}

Powered by Google App Engine
This is Rietveld 408576698