Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1131283004: Prevent SVG children from participating in an ancestor multicol context. (Closed)

Created:
5 years, 7 months ago by mstensho (USE GERRIT)
Modified:
5 years, 7 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Prevent SVG children from participating in an ancestor multicol context. foreignObjects and their children must never see an ancestor flow thread, and we need to convince all parts of the code that they are not "paginated". BUG=486000 R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195164

Patch Set 1 #

Total comments: 1

Patch Set 2 : Initialize m_isPaginated and m_pageLogicalHeightChanged. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, --1 lines) Patch
A LayoutTests/fast/multicol/foreignObject.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/foreignObject-expected.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/span/sole-svg-spanner-with-foreignObject-crash.html View 1 chunk +11 lines, -0 lines 0 comments Download
A + LayoutTests/fast/multicol/span/sole-svg-spanner-with-foreignObject-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutState.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mstensho (USE GERRIT)
https://codereview.chromium.org/1131283004/diff/1/LayoutTests/fast/multicol/foreignObject.html File LayoutTests/fast/multicol/foreignObject.html (right): https://codereview.chromium.org/1131283004/diff/1/LayoutTests/fast/multicol/foreignObject.html#newcode1 LayoutTests/fast/multicol/foreignObject.html:1: <!DOCTYPE html> Note about this test: It doesn't fail ...
5 years, 7 months ago (2015-05-08 21:21:03 UTC) #1
dsinclair
lgtm
5 years, 7 months ago (2015-05-08 23:11:23 UTC) #2
mstensho (USE GERRIT)
@dsinclair: care to take another look? My new assertion failed flakily in many tests. No ...
5 years, 7 months ago (2015-05-10 18:41:22 UTC) #3
leviw_travelin_and_unemployed
lgtm
5 years, 7 months ago (2015-05-11 00:44:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131283004/20001
5 years, 7 months ago (2015-05-11 00:44:54 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 00:47:53 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195164

Powered by Google App Engine
This is Rietveld 408576698