Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: gpu/command_buffer/service/vertex_attrib_manager.h

Issue 1131273005: Fine tune vertex attrib commands handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: working Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/vertex_attrib_manager.h
diff --git a/gpu/command_buffer/service/vertex_attrib_manager.h b/gpu/command_buffer/service/vertex_attrib_manager.h
index b5425e0dc9cb2d33ecf75cbbf727001db2331ef6..f7fd4955dcaff195f7e548d38cf8b15ed4ade789 100644
--- a/gpu/command_buffer/service/vertex_attrib_manager.h
+++ b/gpu/command_buffer/service/vertex_attrib_manager.h
@@ -116,16 +116,13 @@ class GPU_EXPORT VertexAttrib {
GLboolean normalized,
GLsizei gl_stride,
GLsizei real_stride,
- GLsizei offset);
+ GLsizei offset,
+ GLboolean integer);
void SetDivisor(GLsizei divisor) {
divisor_ = divisor;
}
- void SetInteger(GLboolean integer) {
- integer_ = integer;
- }
-
void Unbind(Buffer* buffer);
// The index of this attrib.
@@ -207,7 +204,8 @@ class GPU_EXPORT VertexAttribManager :
GLboolean normalized,
GLsizei gl_stride,
GLsizei real_stride,
- GLsizei offset) {
+ GLsizei offset,
+ GLboolean integer) {
VertexAttrib* attrib = GetVertexAttrib(index);
if (attrib) {
if (attrib->type() == GL_FIXED) {
@@ -216,8 +214,8 @@ class GPU_EXPORT VertexAttribManager :
if (type == GL_FIXED) {
++num_fixed_attribs_;
}
- attrib->SetInfo(
- buffer, size, type, normalized, gl_stride, real_stride, offset);
+ attrib->SetInfo(buffer, size, type, normalized, gl_stride, real_stride,
+ offset, integer);
}
}
@@ -228,13 +226,6 @@ class GPU_EXPORT VertexAttribManager :
}
}
- void SetInteger(GLuint index, GLboolean integer) {
- VertexAttrib* attrib = GetVertexAttrib(index);
- if (attrib) {
- attrib->SetInteger(integer);
- }
- }
-
void SetElementArrayBuffer(Buffer* buffer);
Buffer* element_array_buffer() const { return element_array_buffer_.get(); }
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_autogen.h ('k') | gpu/command_buffer/service/vertex_attrib_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698