Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: gpu/command_buffer/client/gles2_implementation.cc

Issue 1131273005: Fine tune vertex attrib commands handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: working Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/gles2_implementation.cc
diff --git a/gpu/command_buffer/client/gles2_implementation.cc b/gpu/command_buffer/client/gles2_implementation.cc
index b4c2858ca3f04089e32e607f82de3a7245cc374b..38d53b1b9a92c7e88cf574b05f0b99cda4f5cc7e 100644
--- a/gpu/command_buffer/client/gles2_implementation.cc
+++ b/gpu/command_buffer/client/gles2_implementation.cc
@@ -1558,8 +1558,14 @@ void GLES2Implementation::VertexAttribIPointer(
<< stride << ", "
<< ptr << ")");
// Record the info on the client side.
- if (!vertex_array_object_manager_->SetAttribPointer(
- bound_array_buffer_id_, index, size, type, GL_FALSE, stride, ptr)) {
+ if (!vertex_array_object_manager_->SetAttribPointer(bound_array_buffer_id_,
+ index,
+ size,
+ type,
+ GL_FALSE,
+ stride,
+ ptr,
+ GL_TRUE)) {
SetGLError(GL_INVALID_OPERATION, "glVertexAttribIPointer",
"client side arrays are not allowed in vertex array objects.");
return;
@@ -1587,8 +1593,14 @@ void GLES2Implementation::VertexAttribPointer(
<< stride << ", "
<< ptr << ")");
// Record the info on the client side.
- if (!vertex_array_object_manager_->SetAttribPointer(
- bound_array_buffer_id_, index, size, type, normalized, stride, ptr)) {
+ if (!vertex_array_object_manager_->SetAttribPointer(bound_array_buffer_id_,
+ index,
+ size,
+ type,
+ normalized,
+ stride,
+ ptr,
+ GL_FALSE)) {
SetGLError(GL_INVALID_OPERATION, "glVertexAttribPointer",
"client side arrays are not allowed in vertex array objects.");
return;
« no previous file with comments | « gpu/command_buffer/build_gles2_cmd_buffer.py ('k') | gpu/command_buffer/client/vertex_array_object_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698