Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Unified Diff: mojo/converters/surfaces/surfaces_type_converters.cc

Issue 1131253003: cc: Add support for non-2D texture targets to YUVVideoQuad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/jamesr/sky/ Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/cc_messages_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/converters/surfaces/surfaces_type_converters.cc
diff --git a/mojo/converters/surfaces/surfaces_type_converters.cc b/mojo/converters/surfaces/surfaces_type_converters.cc
index f922ebf95c4dddc5b4bb2c28a9d503221ed51d0a..d53e160b45564df12362bc2b5619c2d2cb699964 100644
--- a/mojo/converters/surfaces/surfaces_type_converters.cc
+++ b/mojo/converters/surfaces/surfaces_type_converters.cc
@@ -168,20 +168,17 @@ bool ConvertDrawQuad(const QuadPtr& input,
return false;
cc::YUVVideoDrawQuad* yuv_quad =
render_pass->CreateAndAppendDrawQuad<cc::YUVVideoDrawQuad>();
- yuv_quad->SetAll(sqs,
- input->rect.To<gfx::Rect>(),
- input->opaque_rect.To<gfx::Rect>(),
- input->visible_rect.To<gfx::Rect>(),
- input->needs_blending,
- yuv_state->tex_coord_rect.To<gfx::RectF>(),
- gfx::Size(), // TODO(jamesr): ya texture size
- gfx::Size(), // TODO(jamesr): uv texture size
- yuv_state->y_plane_resource_id,
- yuv_state->u_plane_resource_id,
- yuv_state->v_plane_resource_id,
- yuv_state->a_plane_resource_id,
- static_cast<cc::YUVVideoDrawQuad::ColorSpace>(
- yuv_state->color_space));
+ yuv_quad->SetAll(
+ sqs, input->rect.To<gfx::Rect>(), input->opaque_rect.To<gfx::Rect>(),
+ input->visible_rect.To<gfx::Rect>(), input->needs_blending,
+ gfx::RectF(), // TODO(sky): ya tex coord rect
+ gfx::RectF(), // TODO(sky): uv tex coord rect
+ gfx::Size(), // TODO(sky): ya texture size
+ gfx::Size(), // TODO(sky): uv texture size
+ yuv_state->y_plane_resource_id, yuv_state->u_plane_resource_id,
+ yuv_state->v_plane_resource_id, yuv_state->a_plane_resource_id,
+ static_cast<cc::YUVVideoDrawQuad::ColorSpace>(
+ yuv_state->color_space));
break;
}
default:
@@ -325,7 +322,10 @@ QuadPtr TypeConverter<QuadPtr, cc::DrawQuad>::Convert(
const cc::YUVVideoDrawQuad* yuv_quad =
cc::YUVVideoDrawQuad::MaterialCast(&input);
YUVVideoQuadStatePtr yuv_state = YUVVideoQuadState::New();
- yuv_state->tex_coord_rect = RectF::From(yuv_quad->tex_coord_rect);
+ // TODO(sky): ya_tex_coord_rect
+ // TODO(sky): uv_tex_coord_rect
+ // TODO(sky): ya_texture_size
+ // TODO(sky): uv_texture_size
yuv_state->y_plane_resource_id = yuv_quad->y_plane_resource_id;
yuv_state->u_plane_resource_id = yuv_quad->u_plane_resource_id;
yuv_state->v_plane_resource_id = yuv_quad->v_plane_resource_id;
« no previous file with comments | « content/common/cc_messages_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698