Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3022)

Unified Diff: cc/quads/yuv_video_draw_quad.h

Issue 1131253003: cc: Add support for non-2D texture targets to YUVVideoQuad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/jamesr/sky/ Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/quads/tile_draw_quad.h ('k') | cc/quads/yuv_video_draw_quad.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/quads/yuv_video_draw_quad.h
diff --git a/cc/quads/yuv_video_draw_quad.h b/cc/quads/yuv_video_draw_quad.h
index 03276eb0c890d02405a3fa9258f782d9fd420d6c..deeca2c1cbce07d9b764d52f48c1001e01b7b778 100644
--- a/cc/quads/yuv_video_draw_quad.h
+++ b/cc/quads/yuv_video_draw_quad.h
@@ -29,7 +29,11 @@ class CC_EXPORT YUVVideoDrawQuad : public DrawQuad {
const gfx::Rect& rect,
const gfx::Rect& opaque_rect,
const gfx::Rect& visible_rect,
- const gfx::RectF& tex_coord_rect,
+ // |*_tex_coord_rect| contains non-normalized coordinates.
+ // TODO(reveman): Make the use of normalized vs non-normalized
+ // coordinates consistent across all quad types: crbug.com/487370
+ const gfx::RectF& ya_tex_coord_rect,
+ const gfx::RectF& uv_tex_coord_rect,
const gfx::Size& ya_tex_size,
const gfx::Size& uv_tex_size,
unsigned y_plane_resource_id,
@@ -43,7 +47,11 @@ class CC_EXPORT YUVVideoDrawQuad : public DrawQuad {
const gfx::Rect& opaque_rect,
const gfx::Rect& visible_rect,
bool needs_blending,
- const gfx::RectF& tex_coord_rect,
+ // |*_tex_coord_rect| contains non-normalized coordinates.
+ // TODO(reveman): Make the use of normalized vs non-normalized
+ // coordinates consistent across all quad types: crbug.com/487370
+ const gfx::RectF& ya_tex_coord_rect,
+ const gfx::RectF& uv_tex_coord_rect,
const gfx::Size& ya_tex_size,
const gfx::Size& uv_tex_size,
unsigned y_plane_resource_id,
@@ -52,8 +60,8 @@ class CC_EXPORT YUVVideoDrawQuad : public DrawQuad {
unsigned a_plane_resource_id,
ColorSpace color_space);
- gfx::RectF tex_coord_rect;
- // Empty texture size implies no clamping of texture coordinates.
+ gfx::RectF ya_tex_coord_rect;
+ gfx::RectF uv_tex_coord_rect;
gfx::Size ya_tex_size;
gfx::Size uv_tex_size;
unsigned y_plane_resource_id;
« no previous file with comments | « cc/quads/tile_draw_quad.h ('k') | cc/quads/yuv_video_draw_quad.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698