Issue 113123005: Use SkScalar when aligning glyphs in user space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113123005: Use SkScalar when aligning glyphs in user space. (Closed)

Created:
7 years ago by bungeman-skia

Modified:
7 years ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Use SkScalar when aligning glyphs in user space. Drawing text from paths is done in user space and not in device space. All operations in user space should be performed with SkScalars. BUG=327031 R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=12682

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -11 lines)			Patch
	M	src/core/SkDraw.cpp	View		4 chunks	+34 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

bungeman-skia

When profiling, malloc/free and in general path copy/resizing is rather hot. It appears that we ...

7 years ago (2013-12-13 21:21:14 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r12682.