dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart - Issue 11312245: Fix a couple of bugs in handling of factory redirections.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 11312245: Fix a couple of bugs in handling of factory redirections. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart ('k') | dart/tests/language/const_factory_redirection_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

index ff0644f5d0d4187255f5024dd2cf508550b0ec27..2617bba8cc4d7569e7270cf53f74148a192ec5f4 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

@@ -3145,7 +3145,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {

return;

}

- if (type.element.modifiers.isAbstract() &&

+ if (constructor.getEnclosingClass().isAbstract(compiler) &&

constructor.isGenerativeConstructor()) {

generateAbstractClassInstantiationError(node, type.name.slowToString());

return;