Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: runtime/bin/utils_win.cc

Issue 11312242: Revised CL for customisable logging (replacing printfs). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/platform_linux.cc ('K') | « runtime/bin/socket_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/utils_win.cc
===================================================================
--- runtime/bin/utils_win.cc (revision 14903)
+++ runtime/bin/utils_win.cc (working copy)
@@ -4,6 +4,8 @@
#include <errno.h>
+#include "bin/log.h"
+#include "bin/platform.h"
Ivan Posva 2012/11/15 07:43:17 Where does the need arise for platform.h?
gram 2012/11/15 21:16:50 Removed
#include "bin/utils.h"
static void FormatMessageIntoBuffer(DWORD code,
@@ -19,7 +21,7 @@
NULL);
if (message_size == 0) {
if (GetLastError() != ERROR_INSUFFICIENT_BUFFER) {
- fprintf(stderr, "FormatMessage failed %d\n", GetLastError());
+ Log::PrintErr("FormatMessage failed %d\n", GetLastError());
}
snprintf(buffer, buffer_length, "OS Error %d", code);
}
« runtime/bin/platform_linux.cc ('K') | « runtime/bin/socket_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698