Revised CL for customisable logging (replacing printfs).

runtime/bin/log_android.cc

+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#include <signal.h>
+#include <string.h>
+#include <unistd.h>
+#include <android/log.h>
+
+#include "bin/log.h"

[Ivan Posva, 2012/11/15 07:43:17]

Should be the first include.

[gram, 2012/11/15 21:16:50]

Done.

+
+// TODO(gram): For OS::Print and OS::PrintErr, we should be buffering

[Ivan Posva, 2012/11/15 07:43:17]

Comment is out of date.

[gram, 2012/11/15 21:16:50]

Done.

+// the data and only outputting it when we see a '\n'.
+void Log::Print(const char* format, ...) {
+  va_list args;
+  va_start(args, format);
+  __android_log_vprint(ANDROID_LOG_INFO, "Dart", format, args);
+  va_end(args);
+}
+
+void Log::VFPrint(FILE* stream, const char* format, va_list args) {

[Ivan Posva, 2012/11/15 18:59:44]

Actually thinking about it, this looks like a bad abstraction to me. Instead of
having VFPrint take a FILE* it should just indicate whether you want to print on
out or err, by for example defining a named enum.

[gram, 2012/11/15 21:16:50]

I've removed VFPrint

+  vfprintf(stream, format, args);
+  fflush(stream);
+}
+
+void Log::PrintErr(const char* format, ...) {

[Ivan Posva, 2012/11/15 07:43:17]

Please try to maintain the order of the functions as they were defined in the
header.

[gram, 2012/11/15 21:16:50]

Done.

+  va_list args;
+  va_start(args, format);
+  __android_log_vprint(ANDROID_LOG_ERROR, "Dart", format, args);
+  va_end(args);
+}