Revised CL for customisable logging (replacing printfs).

runtime/bin/file_win.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-#include "bin/file.h"

[Ivan Posva, 2012/11/15 07:43:17]

Where did the include of file.h go? And how can this compile given the many
references to the File class?

[gram, 2012/11/15 21:16:50]

Not sure what happened here; it is restored now.

-
 #include <fcntl.h>
 #include <io.h>
 #include <stdio.h>
 #include <string.h>
 #include <sys/stat.h>
 
+#include "bin/platform.h"

[siva, 2012/11/15 18:46:48]

Why does this need to be included here now, it was not
there in the previous revision?

[gram, 2012/11/15 21:16:50]

Removed

 #include "bin/builtin.h"
+#include "bin/log.h"
 
 class FileHandle {
  public:
   explicit FileHandle(int fd) : fd_(fd) { }
   ~FileHandle() { }
   int fd() const { return fd_; }
   void set_fd(int fd) { fd_ = fd; }
 
  private:
   int fd_;
 
   DISALLOW_COPY_AND_ASSIGN(FileHandle);
 };
 
 
 File::~File() {
   // Close the file (unless it's a standard stream).
   if (handle_->fd() > 2) {
     Close();
   }
   delete handle_;
 }
 
 
 void File::Close() {
   ASSERT(handle_->fd() >= 0);
   int err = close(handle_->fd());
   if (err != 0) {
-    fprintf(stderr, "%s\n", strerror(errno));
+    Log::PrintErr("%s\n", strerror(errno));
   }
   handle_->set_fd(kClosedFd);
 }
 
 
 bool File::IsClosed() {
   return handle_->fd() == kClosedFd;
 }
 
 
@@ skipping 201 matching lines @@
 const char* File::StringEscapedPathSeparator() {
   return "\\\\";
 }
 
 
 File::StdioHandleType File::GetStdioHandleType(int fd) {
   // Treat all stdio handles as pipes. The Windows event handler and
   // socket code will handle the different handle types.
   return kPipe;
 }