Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 11312223: Revert 167487 - Get full WebPluginInfo for the PDF plug-in before enabling it for print preview. (Closed)

Created:
8 years, 1 month ago by Wez
Modified:
8 years, 1 month ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 167487 - Get full WebPluginInfo for the PDF plug-in before enabling it for print preview. This CL coincided with the DuplicateTab test starting to fail due to a prior test failing to unregister a window class; the addition of the AtExitManager could potentially be the cause. See crbug.com/160862. BUG=159902 Review URL: https://chromiumcodereview.appspot.com/11364202 TBR=bauerb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -34 lines) Patch
M chrome/browser/printing/print_preview_tab_controller.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller_unittest.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Wez
8 years, 1 month ago (2012-11-14 00:28:36 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698