Add LIBMTP_Get_File_Chunk() to read an arbitrary amount of data into memory. The existing APIs only…

Add LIBMTP_Get_File_Chunk() to read an arbitrary amount of data into memory. The existing APIs only allow reading the entire file with a progress indicator callback.

BUG=160860
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167836

[Lei Zhang, 2012-11-14 00:26:51]

LIBMTP_Get_File_Chunk() is just a simplified version of
LIBMTP_Get_File_To_File_Descriptor(). Some of the code is duplicated and not
refactored into a helper function for now to make patch maintenance a little
easier.

After this is in, I intend to add ReadFileChunkById/File to mtpd, and then call
it from the Chrome side.

[Jorge Lucangeli Obes, 2012-11-15 01:46:10]

lgtm but please make sure the coding standard in the file is reasonably
consistent.

Since you copied the function, maybe it was already like this, so in that case I
guess it's a pointless fight.

https://codereview.chromium.org/11312222/diff/4001/src/libmtp.c
File src/libmtp.c (right):

https://codereview.chromium.org/11312222/diff/4001/src/libmtp.c#newcode5000
src/libmtp.c:5000: ret = ptp_object_want (params, id,
PTPOBJECT_OBJECTINFO_LOADED, &ob);
I'm not sure what the coding standard is for third_party, but we should be able
to keep it consistent inside one file. Did you write this code from scratch?

[Lei Zhang, 2012-11-15 01:50:11]

https://codereview.chromium.org/11312222/diff/4001/src/libmtp.c
File src/libmtp.c (right):

https://codereview.chromium.org/11312222/diff/4001/src/libmtp.c#newcode5000
src/libmtp.c:5000: ret = ptp_object_want (params, id,
PTPOBJECT_OBJECTINFO_LOADED, &ob);
On 2012/11/15 01:46:10, Jorge Lucangeli Obes wrote:
> I'm not sure what the coding standard is for third_party, but we should be
able
> to keep it consistent inside one file. Did you write this code from scratch?

This is copied from line 5158. The code in this file is not 100% consistent with
itself. :)