"Reverting 14829-14832"

utils/testrunner/layout_test_controller.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // The following set of variables should be set by the caller that
 // #sources this file.
 /** Whether to include elapsed time. */
 
 part of test_controller;
 
@@ skipping 146 matching lines @@
           if (label == 'NONEXISTENT') {
             complete();
           }
         } else if (stdout[i].startsWith(contentMarker)) {
           if (label == null) {
             complete();
           }
           var expectedFileName =
               '$sourceDir${Platform.pathSeparator}'
               '${label.replaceAll("###", "_")
-                      .replaceAll(new RegExp("[^A-Za-z0-9]"),"_")}.txt';
+                      .replaceAll(const RegExp("[^A-Za-z0-9]"),"_")}.txt';
           var expected = new File(expectedFileName);
           if (regenerate) {
             var ostream = expected.openOutputStream(FileMode.WRITE);
             while (i < stdout.length) {
               ostream.writeString(stdout[i]);
               ostream.writeString('\n');
               i++;
             }
             ostream.close();
             pass(start, label);
@@ skipping 75 matching lines @@
           }
         } else if (line.startsWith(contentMarker)) {
           if (label == null) {
             complete();
           }
           var len = int.parse(line.substring(contentMarker.length));
           pos = idx + 1;
           var expectedFileName =
               '$sourceDir${Platform.pathSeparator}'
               '${label.replaceAll("###","_").
-                       replaceAll(new RegExp("[^A-Za-z0-9]"),"_")}.png';
+                       replaceAll(const RegExp("[^A-Za-z0-9]"),"_")}.png';
           var expected = new File(expectedFileName);
           if (regenerate) {
             var ostream = expected.openOutputStream(FileMode.WRITE);
             ostream.writeFrom(stdout, pos, len);
             ostream.close();
             pass(start, label);
           } else if (!expected.existsSync()) {
             fail(start, label, 'No expectation file');
           } else {
             var bytes = expected.readAsBytesSync();
@@ skipping 39 matching lines @@
 
 void runPixelLayoutTests() {
   init();
   runPixelLayoutTest(0);
 }
 
 void runTextLayoutTests() {
   init();
   runTextLayoutTest(0);
 }