- Do not mix scalar values and object fields in RawInstance to

runtime/vm/raw_object.h

Index: runtime/vm/raw_object.h
===================================================================
--- runtime/vm/raw_object.h	(revision 14777)
+++ runtime/vm/raw_object.h	(working copy)
@@ -1235,6 +1235,17 @@
 };
 
 
+// Define an aliases for intptr_t.
+#if defined(ARCH_IS_32_BIT)
+#define RawIntPtrArray RawInt32Array

[cshapiro, 2012/11/12 18:48:45]

Feel free to disregard this but... given that this will store what is
essentially bits as opposed to integers, an unsigned type would seem more
natural.

[Ivan Posva, 2012/11/12 22:01:03]

The external API defines it as intptr_t, which is why I chose the signed
versions here.

+#define IntPtrArray Int32Array
+#elif defined(ARCH_IS_64_BIT)
+#define RawIntPtrArray RawInt64Array
+#define IntPtrArray Int64Array
+#else
+#error Architecture is not 32-bit or 64-bit.
+#endif  // ARCH_IS_32_BIT
+

[cshapiro, 2012/11/12 18:48:45]

2 spaces?

[Ivan Posva, 2012/11/12 22:01:03]

Done.

 class RawByteArray : public RawInstance {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ByteArray);