Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: content/common/indexed_db/indexed_db_dispatcher_unittest.cc

Issue 11312178: Remove legacy IDB backend IPC glue for string-based references. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/indexed_db/indexed_db_dispatcher_unittest.cc
diff --git a/content/common/indexed_db/indexed_db_dispatcher_unittest.cc b/content/common/indexed_db/indexed_db_dispatcher_unittest.cc
index 36f52ca4e184850ea764323ad039275c4d57870e..fc290aed00bfb35219628d031f4bbab671e52301 100644
--- a/content/common/indexed_db/indexed_db_dispatcher_unittest.cc
+++ b/content/common/indexed_db/indexed_db_dispatcher_unittest.cc
@@ -22,7 +22,9 @@ class FakeWebIDBTransaction : public WebKit::WebIDBTransaction {
FakeWebIDBTransaction() {}
};
-TEST(IndexedDBDispatcherTest, ValueSizeTest) {
+// TODO(alecflett): Reenable this test when IDB code in webkit
jsbell 2012/11/12 19:38:50 Add a tracking bug for this and reference it? See
+// enforces size limits.
+TEST(IndexedDBDispatcherTest, DISABLED_ValueSizeTest) {
string16 data;
data.resize(kMaxIDBValueSizeInBytes / sizeof(char16) + 1, 'x');
const bool kIsNull = false;
@@ -34,7 +36,6 @@ TEST(IndexedDBDispatcherTest, ValueSizeTest) {
IndexedDBDispatcher dispatcher;
IndexedDBKey key;
key.SetNumber(0);
- WebKit::WebExceptionCode ec = 0;
dispatcher.RequestIDBObjectStorePut(
value,
key,
@@ -42,10 +43,8 @@ TEST(IndexedDBDispatcherTest, ValueSizeTest) {
static_cast<WebKit::WebIDBCallbacks*>(NULL),
dummy_id,
FakeWebIDBTransaction(),
- WebVector<WebString>(),
- WebVector<WebVector<WebKit::WebIDBKey> >(),
- &ec);
- EXPECT_NE(ec, 0);
+ WebVector<long long>(),
+ WebVector<WebVector<WebKit::WebIDBKey> >());
}
}

Powered by Google App Engine
This is Rietveld 408576698