Issue 11312153: Fix PATH to find cmd\git.exe before bin\git.exe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11312153: Fix PATH to find cmd\git.exe before bin\git.exe. (Closed)

Created:
8 years, 1 month ago by szager

Modified:
8 years, 1 month ago

Reviewers:
cmp, M-A Ruel

CC:
chromium-reviews, cmp+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/

Visibility:
Public.

More Reviews

Description

Fix PATH to find cmd\git.exe before bin\git.exe. cmd\git.exe appeared in the newer (1.8.0) version of msysgit. It appears to do some env setup before invoking bit\git.exe. If that setup is skipped, git may have trouble with commands that use the pager (e.g., `less`). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166792

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/git_bin_packager/files/git.cmd	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cmp

lgtm with note https://codereview.chromium.org/11312153/diff/1/third_party/git_bin_packager/files/git.cmd File third_party/git_bin_packager/files/git.cmd (left): https://codereview.chromium.org/11312153/diff/1/third_party/git_bin_packager/files/git.cmd#oldcode7 third_party/git_bin_packager/files/git.cmd:7: @set PATH=%git_install_root%\bin;%git_install_root%\mingw\bin;%PATH% Your description didn't mention ...

8 years, 1 month ago (2012-11-08 22:35:58 UTC) #2

szager1

8 years, 1 month ago (2012-11-08 22:53:12 UTC) #3

On 2012/11/08 22:35:58, cmp wrote:
> lgtm with note
> 
>
https://codereview.chromium.org/11312153/diff/1/third_party/git_bin_packager/...
> File third_party/git_bin_packager/files/git.cmd (left):
> 
>
https://codereview.chromium.org/11312153/diff/1/third_party/git_bin_packager/...
> third_party/git_bin_packager/files/git.cmd:7: @set
> PATH=%git_install_root%\bin;%git_install_root%\mingw\bin;%PATH%
> Your description didn't mention what happened to mingw.  Is it intentionally
> being removed here?

The mingw path is typically where you put the compiler toolchain that is used to
build msys.  We don't do that; we just ship the pre-built msys, so that path
doesn't exist in our installation.

Expand Messages | Collapse Messages