Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: utils/pub/git_source.dart

Issue 11312133: Pass absolute path to git (redux). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Jiggle the handle. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | utils/pub/io.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/git_source.dart
diff --git a/utils/pub/git_source.dart b/utils/pub/git_source.dart
index 6327638d93ba54925cc3da600db4e351cab060dc..5d7e2d72e15fbd8a13793208f0a7403fe7b6c82c 100644
--- a/utils/pub/git_source.dart
+++ b/utils/pub/git_source.dart
@@ -148,6 +148,12 @@ class GitSource extends Source {
* remote repository. See the manpage for `git clone` for more information.
*/
Future _clone(String from, String to, {bool mirror: false}) {
+ // TODO(rnystrom): For some mysterious reason, the Windows buildbots do not
+ // have the right working directory when pub spawns git, so the relative
+ // path fails. To work around it, just always pass in a full path. Should
+ // figure out what's going on here.
+ from = getFullPath(from);
+
// Git on Windows does not seem to automatically create the destination
// directory.
return ensureDir(to).chain((_) {
« no previous file with comments | « no previous file | utils/pub/io.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698