Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: test/gyp-defines/gyptest-multiple-values.py

Issue 1131213003: Remove the Android generator. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/generator-output/gyptest-top-all.py ('k') | test/hello/gyptest-regyp-output.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/gyp-defines/gyptest-multiple-values.py
diff --git a/test/gyp-defines/gyptest-multiple-values.py b/test/gyp-defines/gyptest-multiple-values.py
index 6764dbd545dcdc6055e5739f52770df9ae895818..67735cce6a872bad15bee733263434e41540ea75 100644
--- a/test/gyp-defines/gyptest-multiple-values.py
+++ b/test/gyp-defines/gyptest-multiple-values.py
@@ -29,12 +29,6 @@ if test.format == 'msvs' and not test.uses_msbuild:
# msvs versions before 2010 don't detect build rule changes not reflected
# in file system timestamps. Rebuild to see differences.
test.build('defines.gyp', rebuild=True)
-elif test.format == 'android':
- # The Android build system doesn't currently have a way to get files whose
- # build rules have changed (but whose timestamps haven't) to be rebuilt.
- # See bug http://code.google.com/p/gyp/issues/detail?id=308
- test.unlink('action.txt')
- test.build('defines.gyp')
else:
test.build('defines.gyp')
test.must_contain('action.txt', 'repeated_value')
« no previous file with comments | « test/generator-output/gyptest-top-all.py ('k') | test/hello/gyptest-regyp-output.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698