Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1131213003: Remove the Android generator. (Closed)

Created:
5 years, 7 months ago by Torne
Modified:
5 years, 7 months ago
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Remove the Android generator. The android generator is no longer used by Chromium (WebView now builds using ninja), is buggy and missing many features, and is unmaintained. BUG= R=bradnelson@google.com, cjhopman@chromium.org, dpranke@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/f34b9aa7c9d6dc368aa01a82f9f847eca15b9e18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2371 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
D buildbot/aosp_manifest.xml View 1 chunk +0 lines, -466 lines 0 comments Download
M buildbot/buildbot_run.py View 4 chunks +2 lines, -115 lines 0 comments Download
M buildbot/commit_queue/cq_config.json View 1 chunk +0 lines, -1 line 0 comments Download
D pylib/gyp/generator/android.py View 1 chunk +0 lines, -1094 lines 0 comments Download
M test/actions/gyptest-all.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/actions/gyptest-default.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/actions/gyptest-generated-header.py View 1 chunk +0 lines, -6 lines 0 comments Download
M test/additional-targets/gyptest-additional.py View 1 chunk +1 line, -1 line 0 comments Download
D test/android/32or64.c View 1 chunk +0 lines, -13 lines 0 comments Download
D test/android/file.in View 1 chunk +0 lines, -1 line 0 comments Download
D test/android/gyptest-host-multilib.py View 1 chunk +0 lines, -32 lines 0 comments Download
D test/android/gyptest-make-functions.py View 1 chunk +0 lines, -24 lines 0 comments Download
D test/android/gyptest-noalias.py View 1 chunk +0 lines, -21 lines 0 comments Download
D test/android/gyptest-settings.py View 1 chunk +0 lines, -24 lines 0 comments Download
D test/android/gyptest-settings-list.py View 1 chunk +0 lines, -24 lines 0 comments Download
D test/android/gyptest-space-filenames.py View 1 chunk +0 lines, -19 lines 0 comments Download
D test/android/hello.c View 1 chunk +0 lines, -12 lines 0 comments Download
D test/android/hello.gyp View 1 chunk +0 lines, -15 lines 0 comments Download
D test/android/host_32or64.gyp View 1 chunk +0 lines, -38 lines 0 comments Download
D test/android/make_functions.gyp View 1 chunk +0 lines, -31 lines 0 comments Download
D test/android/settings.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D test/android/settings-list.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D test/android/space_filenames.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D test/android/writefile.c View 1 chunk +0 lines, -18 lines 0 comments Download
M test/build-option/gyptest-build.py View 1 chunk +0 lines, -6 lines 0 comments Download
M test/builddir/gyptest-all.py View 1 chunk +2 lines, -2 lines 0 comments Download
M test/builddir/gyptest-default.py View 1 chunk +2 lines, -2 lines 0 comments Download
M test/configurations/basics/gyptest-configurations.py View 1 chunk +0 lines, -6 lines 0 comments Download
M test/configurations/inheritance/gyptest-inheritance.py View 1 chunk +0 lines, -6 lines 0 comments Download
M test/copies/gyptest-samedir.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/copies/gyptest-updir.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/escaping/gyptest-colon.py View 1 chunk +1 line, -1 line 0 comments Download
M test/generator-output/gyptest-actions.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/generator-output/gyptest-copies.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/generator-output/gyptest-relocate.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/generator-output/gyptest-rules.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/generator-output/gyptest-subdir2-deep.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/generator-output/gyptest-symlink.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/generator-output/gyptest-top-all.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/gyp-defines/gyptest-multiple-values.py View 1 chunk +0 lines, -6 lines 0 comments Download
M test/hello/gyptest-regyp-output.py View 1 chunk +2 lines, -2 lines 0 comments Download
M test/lib/TestGyp.py View 3 chunks +0 lines, -274 lines 0 comments Download
M test/library/gyptest-shared.py View 1 chunk +0 lines, -6 lines 0 comments Download
M test/library/gyptest-shared-obj-install-path.py View 1 chunk +1 line, -4 lines 0 comments Download
M test/library/gyptest-static.py View 1 chunk +0 lines, -6 lines 0 comments Download
M test/library_dirs/gyptest-library-dirs.py View 1 chunk +1 line, -1 line 0 comments Download
M test/module/gyptest-default.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/no-cpp/gyptest-no-cpp.py View 1 chunk +2 lines, -2 lines 0 comments Download
M test/product/gyptest-product.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/prune_targets/gyptest-prune-targets.py View 1 chunk +0 lines, -1 line 0 comments Download
M test/rules-dirname/gyptest-dirname.py View 1 chunk +1 line, -1 line 0 comments Download
M test/same-target-name-different-directory/gyptest-all.py View 1 chunk +1 line, -1 line 0 comments Download
M test/standalone-static-library/gyptest-standalone-static-library.py View 1 chunk +2 lines, -4 lines 0 comments Download
M test/subdirectory/gyptest-subdir-all.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/subdirectory/gyptest-subdir-default.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Torne
5 years, 7 months ago (2015-05-11 13:44:19 UTC) #2
Dirk Pranke
lgtm!
5 years, 7 months ago (2015-05-12 00:35:06 UTC) #3
cjhopman
lgtm!
5 years, 7 months ago (2015-05-12 00:36:07 UTC) #5
Torne
Hm, apparently this also needs an OWNER for the buildbot change. +bradnelson.
5 years, 7 months ago (2015-05-12 14:56:14 UTC) #7
bradn
lgtm
5 years, 7 months ago (2015-05-12 16:14:58 UTC) #9
Torne
5 years, 7 months ago (2015-05-12 16:51:39 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f34b9aa7c9d6dc368aa01a82f9f847eca15b9e18.

Powered by Google App Engine
This is Rietveld 408576698