Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/io/file_impl.dart

Issue 11312122: Change List constructors. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart
Patch Set: Reupload. Adapt code for List.fixedLength. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/directory_impl.dart ('k') | sdk/lib/isolate/mangler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/file_impl.dart
diff --git a/sdk/lib/io/file_impl.dart b/sdk/lib/io/file_impl.dart
index 8d368389528f430d5e6b8e9c9cf9b4ecd145cdd7..6dd684b93f99143558398308b0cb1e17b24746fa 100644
--- a/sdk/lib/io/file_impl.dart
+++ b/sdk/lib/io/file_impl.dart
@@ -360,7 +360,7 @@ class _File extends _FileBase implements File {
Future<bool> exists() {
_ensureFileService();
- List request = new List(2);
+ List request = new List.fixedLength(2);
request[0] = _EXISTS_REQUEST;
request[1] = _name;
return _fileService.call(request).then((response) {
@@ -381,7 +381,7 @@ class _File extends _FileBase implements File {
Future<File> create() {
_ensureFileService();
- List request = new List(2);
+ List request = new List.fixedLength(2);
request[0] = _CREATE_REQUEST;
request[1] = _name;
return _fileService.call(request).then((response) {
@@ -401,7 +401,7 @@ class _File extends _FileBase implements File {
Future<File> delete() {
_ensureFileService();
- List request = new List(2);
+ List request = new List.fixedLength(2);
request[0] = _DELETE_REQUEST;
request[1] = _name;
return _fileService.call(request).then((response) {
@@ -421,7 +421,7 @@ class _File extends _FileBase implements File {
Future<Directory> directory() {
_ensureFileService();
- List request = new List(2);
+ List request = new List.fixedLength(2);
request[0] = _DIRECTORY_REQUEST;
request[1] = _name;
return _fileService.call(request).then((response) {
@@ -453,7 +453,7 @@ class _File extends _FileBase implements File {
});
return completer.future;
}
- List request = new List(3);
+ List request = new List.fixedLength(3);
request[0] = _OPEN_REQUEST;
request[1] = _name;
request[2] = mode._mode; // Direct int value for serialization.
@@ -467,7 +467,7 @@ class _File extends _FileBase implements File {
Future<int> length() {
_ensureFileService();
- List request = new List(2);
+ List request = new List.fixedLength(2);
request[0] = _LENGTH_FROM_NAME_REQUEST;
request[1] = _name;
return _fileService.call(request).then((response) {
@@ -491,7 +491,7 @@ class _File extends _FileBase implements File {
Future<Date> lastModified() {
_ensureFileService();
- List request = new List(2);
+ List request = new List.fixedLength(2);
request[0] = _LAST_MODIFIED_REQUEST;
request[1] = _name;
return _fileService.call(request).then((response) {
@@ -538,7 +538,7 @@ class _File extends _FileBase implements File {
Future<String> fullPath() {
_ensureFileService();
- List request = new List(2);
+ List request = new List.fixedLength(2);
request[0] = _FULL_PATH_REQUEST;
request[1] = _name;
return _fileService.call(request).then((response) {
@@ -747,7 +747,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
Completer<RandomAccessFile> completer = new Completer<RandomAccessFile>();
if (closed) return _completeWithClosedException(completer);
_ensureFileService();
- List request = new List(2);
+ List request = new List.fixedLength(2);
request[0] = _CLOSE_REQUEST;
request[1] = _id;
// Set the id_ to 0 (NULL) to ensure the no more async requests
@@ -778,7 +778,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
_ensureFileService();
Completer<int> completer = new Completer<int>();
if (closed) return _completeWithClosedException(completer);
- List request = new List(2);
+ List request = new List.fixedLength(2);
request[0] = _READ_BYTE_REQUEST;
request[1] = _id;
return _fileService.call(request).then((response) {
@@ -815,7 +815,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
return completer.future;
};
if (closed) return _completeWithClosedException(completer);
- List request = new List(3);
+ List request = new List.fixedLength(3);
request[0] = _READ_LIST_REQUEST;
request[1] = _id;
request[2] = bytes;
@@ -871,7 +871,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
return completer.future;
}
if (closed) return _completeWithClosedException(completer);
- List request = new List(3);
+ List request = new List.fixedLength(3);
request[0] = _WRITE_BYTE_REQUEST;
request[1] = _id;
request[2] = value;
@@ -926,7 +926,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
return completer.future;
}
- List request = new List(5);
+ List request = new List.fixedLength(5);
request[0] = _WRITE_LIST_REQUEST;
request[1] = _id;
request[2] = result.buffer;
@@ -988,7 +988,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
_ensureFileService();
Completer<int> completer = new Completer<int>();
if (closed) return _completeWithClosedException(completer);
- List request = new List(2);
+ List request = new List.fixedLength(2);
request[0] = _POSITION_REQUEST;
request[1] = _id;
return _fileService.call(request).then((response) {
@@ -1015,7 +1015,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
_ensureFileService();
Completer<RandomAccessFile> completer = new Completer<RandomAccessFile>();
if (closed) return _completeWithClosedException(completer);
- List request = new List(3);
+ List request = new List.fixedLength(3);
request[0] = _SET_POSITION_REQUEST;
request[1] = _id;
request[2] = position;
@@ -1042,7 +1042,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
_ensureFileService();
Completer<RandomAccessFile> completer = new Completer<RandomAccessFile>();
if (closed) return _completeWithClosedException(completer);
- List request = new List(3);
+ List request = new List.fixedLength(3);
request[0] = _TRUNCATE_REQUEST;
request[1] = _id;
request[2] = length;
@@ -1069,7 +1069,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
_ensureFileService();
Completer<int> completer = new Completer<int>();
if (closed) return _completeWithClosedException(completer);
- List request = new List(2);
+ List request = new List.fixedLength(2);
request[0] = _LENGTH_REQUEST;
request[1] = _id;
return _fileService.call(request).then((response) {
@@ -1096,7 +1096,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {
_ensureFileService();
Completer<RandomAccessFile> completer = new Completer<RandomAccessFile>();
if (closed) return _completeWithClosedException(completer);
- List request = new List(2);
+ List request = new List.fixedLength(2);
request[0] = _FLUSH_REQUEST;
request[1] = _id;
return _fileService.call(request).then((response) {
« no previous file with comments | « sdk/lib/io/directory_impl.dart ('k') | sdk/lib/isolate/mangler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698