Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: runtime/lib/array_patch.dart

Issue 11312122: Change List constructors. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart
Patch Set: Address comments and fix. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/array_patch.dart
diff --git a/runtime/lib/array_patch.dart b/runtime/lib/array_patch.dart
index 08ef4822a6035f4a663219a9146403d3eca03e61..f931d596f697317cf6329deed2778ccbb2e2744b 100644
--- a/runtime/lib/array_patch.dart
+++ b/runtime/lib/array_patch.dart
@@ -6,12 +6,45 @@
// returns a _GrowableObjectArray if length is null, otherwise returns
// fixed size array.
patch class _ListImpl<E> {
- /* patch */ factory List([int length = null]) {
- if (length === null) {
- return new _GrowableObjectArray<E>();
- } else {
- return new _ObjectArray<E>(length);
+ /* patch */ factory List([int length = 0]) {
+ if (length is! int || length < 0) {
+ throw new ArgumentError("Length must be a positive integer: $length.");
}
+ _GrowableObjectArray<E> result = new _GrowableObjectArray<E>();
+ if (length != 0) {
Lasse Reichstein Nielsen 2012/11/12 11:31:06 Don't check, just set the length. It's correct for
floitsch 2012/11/12 13:21:50 Done.
+ result.length = length;
+ }
+ return result;
+ }
+
+ /* patch */ factory List.fixedLength(int length, {E fill: null}) {
+ if (length is! int || length < 0) {
+ throw new ArgumentError("Length must be a positive integer: $length.");
+ }
+ _ObjectArray<E> result = new _ObjectArray<E>(length);
+ if (fill != null) {
+ for (int i = 0; i < length; i++) {
+ result[i] = fill;
+ }
+ }
+ return result;
+ }
+
+ /* patch */ factory List.filled(int length, E fill) {
+ if (length is! int || length < 0) {
+ throw new ArgumentError("Length must be a positive integer: $length.");
+ }
+ _GrowableObjectArray<E> result =
+ new _GrowableObjectArray<E>.withCapacity(length < 4 ? 4 : length);
+ if (length != 0) {
+ result.length = length;
+ if (fill != null) {
+ for (int i = 0; i < length; i++) {
+ result[i] = fill;
+ }
+ }
+ }
+ return result;
}
/* patch */ factory List.from(Iterable<E> other) {
« no previous file with comments | « no previous file | runtime/lib/string_base.dart » ('j') | sdk/lib/_internal/compiler/implementation/lib/core_patch.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698