Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: runtime/vm/parser.cc

Issue 11312109: Make sure setter does not conflict with method (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/field7_negative_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 14588)
+++ runtime/vm/parser.cc (working copy)
@@ -582,9 +582,11 @@
fields_(GrowableObjectArray::Handle(GrowableObjectArray::New())) {
}
+ // Parameter 'name' is the unmangled name, i.e. without the setter
+ // name mangling.
bool FunctionNameExists(const String& name, RawFunction::Kind kind) const {
// First check if a function or field of same name exists.
- if (FunctionExists(name)) {
+ if ((kind != RawFunction::kSetterFunction) && FunctionExists(name)) {
return true;
}
// Now check whether there is a field and whether its implicit getter
« no previous file with comments | « no previous file | tests/language/field7_negative_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698