Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 11312095: Fix various inheritance bugs (Closed)

Created:
8 years, 1 month ago by hausner
Modified:
8 years, 1 month ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix various inheritance bugs Fields can be overridden by subclasses A setter does not conflict with a method Eliminate outdated tests Fixes issue 6482 Committed: https://code.google.com/p/dart/source/detail?r=14583

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -182 lines) Patch
M runtime/vm/class_finalizer.cc View 1 7 chunks +36 lines, -46 lines 0 comments Download
M runtime/vm/parser.cc View 1 8 chunks +84 lines, -36 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +6 lines, -10 lines 0 comments Download
D tests/language/field7a_negative_test.dart View 1 1 chunk +0 lines, -23 lines 0 comments Download
M tests/language/language.status View 1 7 chunks +1 line, -13 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 chunks +0 lines, -2 lines 0 comments Download
D tests/language/override_field_method3_negative_test.dart View 1 1 chunk +0 lines, -22 lines 0 comments Download
D tests/language/override_field_method6_negative_test.dart View 1 1 chunk +0 lines, -22 lines 0 comments Download
M tests/language/override_field_test.dart View 1 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hausner
8 years, 1 month ago (2012-11-06 01:25:39 UTC) #1
regis
8 years, 1 month ago (2012-11-06 16:57:52 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698