Plumbing for rendering stats subscriber.

webkit/compositor_bindings/web_layer_tree_view_impl.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebLayerTreeViewImpl_h
 #define WebLayerTreeViewImpl_h
 
 #include "base/memory/scoped_ptr.h"
 #include "cc/layer_tree_host_client.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebLayerTreeView.h"
@@ skipping 31 matching lines @@
     virtual void startPageScaleAnimation(const WebPoint& destination, bool useAnchor, float newPageScale, double durationSec) OVERRIDE;
     virtual void setNeedsAnimate() OVERRIDE;
     virtual void setNeedsRedraw() OVERRIDE;
     virtual bool commitRequested() const OVERRIDE;
     virtual void composite() OVERRIDE;
     virtual void updateAnimations(double frameBeginTime) OVERRIDE;
     virtual bool compositeAndReadback(void *pixels, const WebRect&) OVERRIDE;
     virtual void finishAllRendering() OVERRIDE;
     virtual void setDeferCommits(bool deferCommits) OVERRIDE;
     virtual void renderingStats(WebRenderingStats&) const OVERRIDE;
+#ifdef RENDERING_STATS_SUBSCRIBER
+    virtual void startRecordingRenderingStats() const OVERRIDE { }

[danakj, 2012/11/02 21:15:19]

If you land the webkit side first, and don't make them pure virtual, then you
can probably get away without any ifdef magic?

[hartmanng, 2012/11/05 16:09:30]

Unless there's a strong consensus that this is the better way to do it, I'd
prefer to leave it as-is for now. I feel like this method "should" be pure
virtual, if nothing else it's consistent with the existing renderingStats()
method.

Plus I will have a 3rd patch regardless to plumb in the final javascript parts
(which can't land until after http://codereview.chromium.org/11198005 lands).

+    virtual void stopRecordingRenderingStats(WebRenderingStats& stats) const OVERRIDE { }
+#endif /* ifdef RENDERING_STATS_SUBSCRIBER */

[danakj, 2012/11/02 21:15:19]

nit: // RENDERING_STATS_SUBSCRIBER

(c++ style)

[hartmanng, 2012/11/05 16:09:30]

Done.

     virtual void setFontAtlas(SkBitmap, WebRect asciiToRectTable[128], int fontHeight) OVERRIDE;
     virtual void loseCompositorContext(int numTimes) OVERRIDE;
 
     // cc::LayerTreeHostClient implementation.
     virtual void willBeginFrame() OVERRIDE;
     virtual void didBeginFrame() OVERRIDE;
     virtual void animate(double monotonicFrameBeginTime) OVERRIDE;
     virtual void layout() OVERRIDE;
     virtual void applyScrollAndScale(const cc::IntSize& scrollDelta, float pageScale) OVERRIDE;
     virtual scoped_ptr<WebCompositorOutputSurface> createOutputSurface() OVERRIDE;
     virtual void didRecreateOutputSurface(bool success) OVERRIDE;
     virtual scoped_ptr<cc::InputHandler> createInputHandler() OVERRIDE;
     virtual void willCommit() OVERRIDE;
     virtual void didCommit() OVERRIDE;
     virtual void didCommitAndDrawFrame() OVERRIDE;
     virtual void didCompleteSwapBuffers() OVERRIDE;
     virtual void scheduleComposite() OVERRIDE;
 
 private:
     WebLayerTreeViewClient* m_client;
     scoped_ptr<cc::LayerTreeHost> m_layerTreeHost;
 };
 
 } // namespace WebKit
 
 #endif // WebLayerTreeViewImpl_h