Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1131183004: Replace page id for updating the history offset. (Closed)

Created:
5 years, 7 months ago by Avi (use Gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace page id for updating the history offset. BUG=369661 TEST=All navigation tests remain green. Committed: https://crrev.com/1e53d034efe6813bf0f2cfe6dc2658c37afe192c Cr-Commit-Position: refs/heads/master@{#329699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Avi (use Gerrit)
This is looking solid from the crash reports, so I want to sub this in.
5 years, 7 months ago (2015-05-13 15:04:26 UTC) #2
Charlie Reis
LGTM!
5 years, 7 months ago (2015-05-13 17:15:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131183004/1
5 years, 7 months ago (2015-05-13 18:50:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 19:48:51 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 19:49:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e53d034efe6813bf0f2cfe6dc2658c37afe192c
Cr-Commit-Position: refs/heads/master@{#329699}

Powered by Google App Engine
This is Rietveld 408576698