Issue 1131183004: Replace page id for updating the history offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1131183004: Replace page id for updating the history offset. (Closed)

Created:
5 years, 7 months ago by Avi (use Gerrit)

Modified:
5 years, 7 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Replace page id for updating the history offset. BUG=369661 TEST=All navigation tests remain green. Committed: https://crrev.com/1e53d034efe6813bf0f2cfe6dc2658c37afe192c Cr-Commit-Position: refs/heads/master@{#329699}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	content/renderer/render_frame_impl.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Avi (use Gerrit)

This is looking solid from the crash reports, so I want to sub this in.

5 years, 7 months ago (2015-05-13 15:04:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131183004/1

5 years, 7 months ago (2015-05-13 18:50:10 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-13 19:49:45 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1e53d034efe6813bf0f2cfe6dc2658c37afe192c
Cr-Commit-Position: refs/heads/master@{#329699}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages